Update tags_spec for DynamoDB.Table #119
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We can now retrieve DynamoDB.Table tag list. Note: if boto3's documentation (http://boto3.readthedocs.io/en/latest/reference/services/dynamodb.html#DynamoDB.Client.list_tags_of_resource) and AWS API's documentation (https://docs.aws.amazon.com/amazondynamodb/latest/APIReference/API_ListTagsOfResource.html), the API call is described as having the "NextToken" mechanism implemented. As far as I could see, skew's implementation relies on boto3's can_paginate / get_paginator to handle this. But it seems that boto3's latest version do not have a paginator for the list_tags_of_resource() call. I may have understood all this wrongly of course, but if it were true, we *could* loose some of the tags.
|
Given the low maximum number of tags on resources, I suspect that pragmatically the API clients opt to ignore pagination, as having multiple pages would require Amazon changing their tag count limit first. The API is being more conservative. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can now retrieve DynamoDB.Table tag list.
Note: if boto3's documentation (http://boto3.readthedocs.io/en/latest/reference/services/dynamodb.html#DynamoDB.Client.list_tags_of_resource)
and AWS API's documentation (https://docs.aws.amazon.com/amazondynamodb/latest/APIReference/API_ListTagsOfResource.html),
the API call is described as having the "NextToken" mechanism implemented.
As far as I could see, skew's implementation relies on boto3's
can_paginate / get_paginator to handle this.
But it seems that boto3's latest version do not have a paginator
for the list_tags_of_resource() call.
I may have understood all this wrongly of course, but if it
were true, we could loose some of the tags.