Skip to content

Conversation

@NanoNabla
Copy link
Collaborator

@NanoNabla NanoNabla commented Jul 8, 2025

  • Makes bindings compatible to Score-P 9.0 and 9.1
  • Updates C/I Tests for new Python Version
  • Changes Ubuntu PPA
  • Fixes migration to setuptools

Open Issues

@NanoNabla NanoNabla requested a review from bertwesarg July 8, 2025 14:49
README.md Outdated
Please make sure that `scorep-config` is in your `PATH` variable.

For Ubuntu LTS systems there is a non-official ppa of Score-P available: https://launchpad.net/~andreasgocht/+archive/ubuntu/scorep .
For Ubuntu LTS systems there is a official ppa of Score-P available: https://launchpad.net/~score-p/+archive/ubuntu/releases .
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure if "official" here could be misinterpreted as "official from canonical". maybe something like:

The Score-P community provides a ppa for Ubuntu LTS releases here: …

btw, any plans for non-x86-64 packages?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it were maintained by Canonical, it would be included in the standard repository rather than a PPA. Nevertheless, I’ll clarify that point.

I could also look into building ARM packages. It hasn’t been on my radar so far, since I don’t personally know many people using ARM-based desktop machines running Ubuntu. But ARM does seem to be an emerging trend.

@foreach_instrumenter
def test_io(scorep_env, instrumenter):
trace_path = get_trace_path(scorep_env)
scorep_env["SCOREP_IO_POSIX"] = "true"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just an idea: maybe set this env also if --io=posix was specified on the command line, that smoothes the transition for Python users. scorep(-config) prints a decprecation warning, the bindings should print, that they exported SCOREP_IO_POSIX=true, the latter only if it is not yet set in the env

no_instrumenter = True
elif elem == "--noinstrumenter":
no_instrumenter = True
elif elem == "--io=runtime:posix" or elem == "--io=posix":
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
elif elem == "--io=runtime:posix" or elem == "--io=posix":
elif elem in ("--io=runtime:posix", "--io=posix):

no_instrumenter = True
elif elem == "--io=runtime:posix" or elem == "--io=posix":
if "SCOREP_IO_POSIX" in os.environ:
print_err("scorep: Warning: The option '--io=runtime:posix' is deprecated.")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
print_err("scorep: Warning: The option '--io=runtime:posix' is deprecated.")
print_err(f"scorep: Warning: The option '{elem}' is deprecated.")

elif elem == "--io=runtime:posix" or elem == "--io=posix":
if "SCOREP_IO_POSIX" in os.environ:
print_err("scorep: Warning: The option '--io=runtime:posix' is deprecated.")
print_err(" Please set the environment variable 'SCOREP_IO_POSIX=true' instead.")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
print_err(" Please set the environment variable 'SCOREP_IO_POSIX=true' instead.")
print_err(f" Will not overwrite existing value for environment variable 'SCOREP_IO_POSIX={os.environ['SCOREP_IO_POSIX']}'.")

@NanoNabla NanoNabla merged commit 45e965b into master Jul 31, 2025
18 of 26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants