-
Notifications
You must be signed in to change notification settings - Fork 13
Updates to Score-P 9 #172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates to Score-P 9 #172
Conversation
README.md
Outdated
| Please make sure that `scorep-config` is in your `PATH` variable. | ||
|
|
||
| For Ubuntu LTS systems there is a non-official ppa of Score-P available: https://launchpad.net/~andreasgocht/+archive/ubuntu/scorep . | ||
| For Ubuntu LTS systems there is a official ppa of Score-P available: https://launchpad.net/~score-p/+archive/ubuntu/releases . |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not sure if "official" here could be misinterpreted as "official from canonical". maybe something like:
The Score-P community provides a ppa for Ubuntu LTS releases here: …
btw, any plans for non-x86-64 packages?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If it were maintained by Canonical, it would be included in the standard repository rather than a PPA. Nevertheless, I’ll clarify that point.
I could also look into building ARM packages. It hasn’t been on my radar so far, since I don’t personally know many people using ARM-based desktop machines running Ubuntu. But ARM does seem to be an emerging trend.
| @foreach_instrumenter | ||
| def test_io(scorep_env, instrumenter): | ||
| trace_path = get_trace_path(scorep_env) | ||
| scorep_env["SCOREP_IO_POSIX"] = "true" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just an idea: maybe set this env also if --io=posix was specified on the command line, that smoothes the transition for Python users. scorep(-config) prints a decprecation warning, the bindings should print, that they exported SCOREP_IO_POSIX=true, the latter only if it is not yet set in the env
Score-P uses the full signature and not only the name of I/O calls Score-P moves --io=runtime:posix into the env
Since Score-P using Gotcha pthread creates a lot of unnecessary events
scorep/__main__.py
Outdated
| no_instrumenter = True | ||
| elif elem == "--noinstrumenter": | ||
| no_instrumenter = True | ||
| elif elem == "--io=runtime:posix" or elem == "--io=posix": |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| elif elem == "--io=runtime:posix" or elem == "--io=posix": | |
| elif elem in ("--io=runtime:posix", "--io=posix): |
scorep/__main__.py
Outdated
| no_instrumenter = True | ||
| elif elem == "--io=runtime:posix" or elem == "--io=posix": | ||
| if "SCOREP_IO_POSIX" in os.environ: | ||
| print_err("scorep: Warning: The option '--io=runtime:posix' is deprecated.") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| print_err("scorep: Warning: The option '--io=runtime:posix' is deprecated.") | |
| print_err(f"scorep: Warning: The option '{elem}' is deprecated.") |
scorep/__main__.py
Outdated
| elif elem == "--io=runtime:posix" or elem == "--io=posix": | ||
| if "SCOREP_IO_POSIX" in os.environ: | ||
| print_err("scorep: Warning: The option '--io=runtime:posix' is deprecated.") | ||
| print_err(" Please set the environment variable 'SCOREP_IO_POSIX=true' instead.") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| print_err(" Please set the environment variable 'SCOREP_IO_POSIX=true' instead.") | |
| print_err(f" Will not overwrite existing value for environment variable 'SCOREP_IO_POSIX={os.environ['SCOREP_IO_POSIX']}'.") |
Open Issues
Class:functionbreak on Python 3.13, see Lot of pthread events because of Gotcha #171