Linux build fails

[apss-pohl]

Hi,
i just updated PHP-CPP to latest version and compiled it successfully.
When i tried to compile php-gtk3 next i get this error, must not be php-cpp related at all - i didn`t compile on linux for a while..

[scorninpc]

I cannot do attention now, but i'll try this at home today

What php version are you trying?

is the php-cpp repo version?

[apss-pohl]

Yes, standard PHP-CPP and i compile for 7.4.33

[scorninpc]

I always use this repository to compile php 8 https://github.com/fast-debug/PHP-CPP.git

the original repository took many years to merge pull requests, so this guy just did these merges

on my first attempt to make the error occur, it did not occur, because I was using this repository

when I realized, I switched to the official repository, and the error started to occur

this makes me believe that at some point the original php-cpp changed something and caused php-gtk3 to break

Is it possible for you to test with this repository instead of the official one?

[apss-pohl]

Same here, it works with fast-debug ootb. I used to use this repo, too. Unfortunately it became stale, while there haven been changes in the original repo this year releasing version 2.4.3 (fast-debug: 2.3.5). It is very unsatisfying with PHP-CPP. For windows non of both works ootb and you need manual changes.

The issue seems to be here:
https://github.com/CopernicaMarketingSoftware/PHP-CPP/blob/master/include/value.h#L59
Makes this unusable:
https://github.com/scorninpc/php-gtk3/blob/master/main.cpp#L4384

I used ChatGPT to try to fix it but i could not find a solution. There are some more issues with other parts of the codebase i was able to find a solution (you can find the parts here: 4ef223e)

I also tried the windows build, which fails, too. Some constructors are missing int he current codebase, i opened a PR (#165).

[scorninpc]

It's alot change, thank you

I'm going to this way to fix this problem too

[apss-pohl]

Let me know if i should open a PR for those fixes already. I will still not build using original PHP-CPP but it seems to work with fast-debug, too

[scorninpc]

You're doing a lot of return handling. My fear is that this is a lot more work than it needs to be. Doing this for every method would be a lot of work. I noticed that you've made a lot of casting changes, which may be a setting for the compiler version (or the version of C++) you're using. I'm trying to finish a virtual machine to do Windows compilation, and rewrite the documentation for it, so if you could put this aside for a while, that would be a good idea.

[apss-pohl]

Sure, let me know if i should open a PR at any time. Key problem is this guy:

https://github.com/CopernicaMarketingSoftware/PHP-CPP/blob/master/include/value.h#L59
Makes this unusable:
https://github.com/scorninpc/php-gtk3/blob/master/main.cpp#L4384

If i comment this i can build the module but it is unusable.

[scorninpc]

Maybe guys on PHP-CPP can help. Try open a issue about that, what do you think?

[apss-pohl]

I am watching this repo and there is barely an answer, i dont expect his to happen. They will most likely state that we need to change our code

[scorninpc]

can you provide a .vsproject file and paths that you are using for php, php-cpp and php-gtk3? ou a zip "all-in-one"?

[apss-pohl]

Unfortunately ist most likely not gonna work, also my path are pretty different. Will sent you an email but might be tricky..

[scorninpc]

I'm very stucked on windows build

I've tested all forks and cannot compile on vs 2022 =/

[apss-pohl]

You can try may branch here:
https://github.com/apss-pohl/PHP-CPP-win/tree/fork

And maybe switch to english, otherwise i cant help at all :)