🐛 exclude undefined itemprop

scottnath · scottnath · commit 3c632f8da3cf · 2024-04-10T13:13:11.000-04:00
diff --git a/src/devto/post/html.js b/src/devto/post/html.js
@@ -15,7 +15,7 @@ function html(content) {
     `
   }
 
-  const itemprop = content.schema_itemprop !== '' ? `itemprop=${content.schema_itemprop}` : '';
+  const itemprop = content.schema_itemprop && content.schema_itemprop !== '' ? `itemprop=${content.schema_itemprop}` : '';
 
   return `
     <span aria-label="dev.to article" class="post" ${itemprop} itemscope itemtype="https://schema.org/Article">
diff --git a/src/devto/user/html.js b/src/devto/user/html.js
@@ -17,7 +17,7 @@ function html(content) {
     `
   }
 
-  const itemprop = content.schema_itemprop !== '' ? `itemprop=${content.schema_itemprop}` : '';
+  const itemprop = content.schema_itemprop && content.schema_itemprop !== '' ? `itemprop=${content.schema_itemprop}` : '';
 
   return `
     <section aria-label="dev.to user profile" ${itemprop} itemscope itemtype="https://schema.org/ProfilePage">
diff --git a/src/github/repository/html.js b/src/github/repository/html.js
@@ -18,7 +18,7 @@ function html(content) {
     `
   }
 
-  const itemprop = content.schema_itemprop !== '' ? `itemprop=${content.schema_itemprop}` : '';
+  const itemprop = content.schema_itemprop && content.schema_itemprop !== '' ? `itemprop=${content.schema_itemprop}` : '';
 
   return `
     <section aria-label="GitHub repository" class="repo" ${itemprop} itemscope itemtype="https://schema.org/SoftwareSourceCode">
diff --git a/src/github/user/html.js b/src/github/user/html.js
@@ -19,7 +19,7 @@ function html(content) {
       `
     }
 
-    const itemprop = content.schema_itemprop !== '' ? `itemprop=${content.schema_itemprop}` : '';
+    const itemprop = content.schema_itemprop && content.schema_itemprop !== '' ? `itemprop=${content.schema_itemprop}` : '';
     
     return `
       <section aria-label="GitHub user profile" ${itemprop} itemscope itemtype="https://schema.org/ProfilePage">

Original file line number	Diff line number	Diff line change
`@@ -15,7 +15,7 @@ function html(content) {`
`15`	`15`	`
`16`	`16`	`}`
`17`	`17`
`18`		- const itemprop = content.schema_itemprop !== '' ? `itemprop=${content.schema_itemprop}` : '';
	`18`	+ const itemprop = content.schema_itemprop && content.schema_itemprop !== '' ? `itemprop=${content.schema_itemprop}` : '';
`19`	`19`
`20`	`20`	return `
`21`	`21`	`<span aria-label="dev.to article" class="post" ${itemprop} itemscope itemtype="https://schema.org/Article">`
Original file line number	Diff line number	Diff line change
`@@ -17,7 +17,7 @@ function html(content) {`
`17`	`17`	`
`18`	`18`	`}`
`19`	`19`
`20`		- const itemprop = content.schema_itemprop !== '' ? `itemprop=${content.schema_itemprop}` : '';
	`20`	+ const itemprop = content.schema_itemprop && content.schema_itemprop !== '' ? `itemprop=${content.schema_itemprop}` : '';
`21`	`21`
`22`	`22`	return `
`23`	`23`	`<section aria-label="dev.to user profile" ${itemprop} itemscope itemtype="https://schema.org/ProfilePage">`
Original file line number	Diff line number	Diff line change
`@@ -18,7 +18,7 @@ function html(content) {`
`18`	`18`	`
`19`	`19`	`}`
`20`	`20`
`21`		- const itemprop = content.schema_itemprop !== '' ? `itemprop=${content.schema_itemprop}` : '';
	`21`	+ const itemprop = content.schema_itemprop && content.schema_itemprop !== '' ? `itemprop=${content.schema_itemprop}` : '';
`22`	`22`
`23`	`23`	return `
`24`	`24`	`<section aria-label="GitHub repository" class="repo" ${itemprop} itemscope itemtype="https://schema.org/SoftwareSourceCode">`
Original file line number	Diff line number	Diff line change
`@@ -19,7 +19,7 @@ function html(content) {`
`19`	`19`	`
`20`	`20`	`}`
`21`	`21`
`22`		- const itemprop = content.schema_itemprop !== '' ? `itemprop=${content.schema_itemprop}` : '';
	`22`	+ const itemprop = content.schema_itemprop && content.schema_itemprop !== '' ? `itemprop=${content.schema_itemprop}` : '';
`23`	`23`
`24`	`24`	return `
`25`	`25`	`<section aria-label="GitHub user profile" ${itemprop} itemscope itemtype="https://schema.org/ProfilePage">`