Skip to content

Conversation

@lolgab
Copy link
Contributor

@lolgab lolgab commented Oct 18, 2025

No description provided.

Copy link
Contributor

@tgodzik tgodzik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tgodzik tgodzik merged commit b707531 into scoverage:main Oct 20, 2025
3 checks passed
@lolgab lolgab deleted the update-scalac-plugin branch October 20, 2025 12:36
@lolgab
Copy link
Contributor Author

lolgab commented Oct 20, 2025

Can we have a new release with this?

@tgodzik
Copy link
Contributor

tgodzik commented Oct 20, 2025

I wanted to add a fallback for older versions. Will do that most likely tomorrow

@lolgab
Copy link
Contributor Author

lolgab commented Oct 21, 2025

So you want to derive scoverageVersion from scalaVersion? I see.
But consider that the plugin usually supports the last three Scala Versions, now it supports two, it's not the end of the world, and people can set scoverageVersion. Moreover someone is going to update exactly when updating to Scala 2.13.17 to fix the error.

@tgodzik
Copy link
Contributor

tgodzik commented Oct 21, 2025

The release is running https://github.com/scoverage/sbt-scoverage/actions/runs/18684703234

I added the fallback just in case, though there might be some issues with SIP-51 anyway, but that was most likely happening with 2.3.1 anyway

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants