Fix different compilation warnings #253
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are two remaining kinds of warnings, which cannot be fixed simply: 1. [warn] .../scalac-scoverage-plugin/src/main/scala/scoverage/coverage.scala:39:80: object DeprecatedDoubleOrdering in object Ordering is deprecated (since 2.13.0): There are multiple ways to order Doubles (Ordering.Double.TotalOrdering, Ordering.Double.IeeeOrdering). Specify one by using a local import, assigning an implicit val, or passing it explicitly. See the documentation for details. [warn] def risks(limit: Int) = classes.toSeq.sortBy(_.statementCount).reverse.sortBy(_.statementCoverage).take(limit) [warn] ^ There are no Ordering.Double.TotalOrdering and Ordering.Double.IeeeOrdering classes in previous Scala versions. 2. [warn] .../scalac-scoverage-plugin/src/test/scala/scoverage/ScoverageCompiler.scala:71:97: class Reporter in package reporters is deprecated (since 2.13.0): Use reflect.internal.Reporter [warn] class ScoverageCompiler(settings: scala.tools.nsc.Settings, reporter: scala.tools.nsc.reporters.Reporter) 'reflect.internal.Reporter' class cannot be used because 'scoverage.ScoverageCompiler' class extends 'scala.tools.nsc.Global' class, and it requires 'scala.tools.nsc.reporters.Reporter' as a constructor parameter.
…cation warnings
All warning are macro-related and reported when Scala version is >= 2.11. There were three kinds:
1.
scoverage_snippet6266375223143133247.scala:5: warning: macro defs must have explicitly specified return types (inference of Unit from macro impl's c.Expr[Unit] is deprecated and is going to stop working in 2.12)
def test = macro testImpl
^
2.
scoverage_snippet6266375223143133247.scala:6: warning: type Context in package macros is deprecated: Use blackbox.Context or whitebox.Context instead
def testImpl(c: Context): c.Expr[Unit] = {
^
3.
scoverage_snippet6689360552943102771.scala:6: warning: method literal in trait ExprUtils is deprecated: Use quasiquotes instead
def poly[T: c.WeakTypeTag] = c.literal(c.weakTypeOf[T].toString)
^
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From time to time it's good to fix the warnings, because they sometimes turn into errors in next Scala versions.