Don't scan all statements on each hit -- there may be very many of them #37
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sksamuel
added a commit
that referenced
this pull request
May 15, 2014
Don't scan all statements on each hit -- there may be very many of them
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we store the statements in a hash-map by id, then we can do a hash lookup when matching invocation ids to statement objects, rather than a "find" which needs to scan all statements.
This takes my test run (
sbt scoverage:test, without a "clean") from 3m22 to 1m28. This number may overstate the improvement; I haven't done very many tests.