Skip to content

PR for issue #58 (HTML report generation fails on classes in default package) #68

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 15, 2014
Merged

PR for issue #58 (HTML report generation fails on classes in default package) #68

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions scalac-scoverage-plugin/src/main/scala/scoverage/report/ScoverageHtmlWriter.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ class ScoverageHtmlWriter(sourceDirectory: File, outputDir: File) {
}

def write(pack: MeasuredPackage) {
val file = new File(outputDir.getAbsolutePath + "/" + pack.name.replace('.', '/') + "/package.html")
val file = new File(outputDir.getAbsolutePath + "/" + pack.name.replace("<empty>", "(empty)").replace('.', '/') + "/package.html")
file.getParentFile.mkdirs()
FileUtils.write(file, packageClasses(pack).toString())
pack.files.foreach(write(_, file.getParentFile))
Expand Down Expand Up @@ -215,7 +215,7 @@ class ScoverageHtmlWriter(sourceDirectory: File, outputDir: File) {
val value = fileRelativeToSource.getName

if (addPath && path.eq(null)) {
"<empty>/" + value
"(empty)/" + value
} else if (addPath && path.ne("")) {
// (Normalise the pathSeparator to "/" in case we are running on Windows)
fileRelativeToSource.toString.replace(File.separator, "/")
Expand Down Expand Up @@ -301,7 +301,7 @@ class ScoverageHtmlWriter(sourceDirectory: File, outputDir: File) {
</tr>{coverage.packages.map(arg =>
<tr>
<td>
<a href={arg.name.replace('.', '/') + "/package.html"} target="mainFrame">
<a href={arg.name.replace("<empty>", "(empty)").replace('.', '/') + "/package.html"} target="mainFrame">
{arg.name}
</a>{arg.statementCoverageFormatted}
%
Expand Down