Skip to content

add rendering_stage parameter to ScrapeConfig #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 27, 2025
Merged

add rendering_stage parameter to ScrapeConfig #32

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion scrapfly/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
__version__ = '0.8.22'
__version__ = '0.8.23'

from typing import Tuple
from .errors import ScrapflyError
Expand Down
8 changes: 7 additions & 1 deletion scrapfly/scrape_config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
from enum import Enum
from urllib.parse import urlencode, quote_plus
from base64 import urlsafe_b64encode
from typing import Optional, List, Dict, Iterable, Union, Set
from typing import Literal, Optional, List, Dict, Iterable, Union, Set
from requests.structures import CaseInsensitiveDict

from .api_config import BaseApiConfig
Expand Down Expand Up @@ -92,6 +92,7 @@ class ScrapeConfig(BaseApiConfig):
headers: Optional[CaseInsensitiveDict] = None
js: str = None
rendering_wait: int = None
rendering_stage: Literal["complete", "domcontentloaded"] = "complete"
wait_for_selector: Optional[str] = None
session_sticky_proxy:bool = True
screenshots:Optional[Dict]=None
Expand Down Expand Up @@ -136,6 +137,7 @@ def __init__(
headers: Optional[Union[CaseInsensitiveDict, Dict[str, str]]] = None,
js: str = None,
rendering_wait: int = None,
rendering_stage: Literal["complete", "domcontentloaded"] = "complete",
wait_for_selector: Optional[str] = None,
screenshots:Optional[Dict]=None,
screenshot_flags: Optional[List[ScreenshotFlag]] = None,
Expand Down Expand Up @@ -186,6 +188,7 @@ def __init__(
self.data = data
self.js = js
self.rendering_wait = rendering_wait
self.rendering_stage = rendering_stage
self.raise_on_upstream_error = raise_on_upstream_error
self.screenshots = screenshots
self.screenshot_flags = screenshot_flags
Expand Down Expand Up @@ -270,6 +273,9 @@ def to_api_params(self, key:str) -> Dict:

if self.rendering_wait:
params['rendering_wait'] = self.rendering_wait

if self.rendering_stage:
params['rendering_stage'] = self.rendering_stage

if self.screenshots is not None:
for name, element in self.screenshots.items():
Expand Down