Skip to content

Conversation

@Kebniss
Copy link
Contributor

@Kebniss Kebniss commented Nov 29, 2018

as explained in #99 errors='ignore' was not universal.

I wanted to add a test but I don't know how to test exceptions

@Kebniss Kebniss requested a review from lopuhin November 29, 2018 04:56
@codecov
Copy link

codecov bot commented Nov 29, 2018

Codecov Report

Merging #100 into master will decrease coverage by 1.4%.
The diff coverage is 69.23%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #100      +/-   ##
=========================================
- Coverage    88.7%   87.3%   -1.41%     
=========================================
  Files          11      11              
  Lines         434     457      +23     
  Branches       89      97       +8     
=========================================
+ Hits          385     399      +14     
- Misses         44      52       +8     
- Partials        5       6       +1
Impacted Files Coverage Δ
extruct/_extruct.py 73.33% <69.23%> (-5.52%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c3ef088...49a8570. Read the comment docs.

Copy link
Member

@lopuhin lopuhin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Kebniss , looks good 👍 left one small comment. Regarding testing, passing an empty string as html will trigger an error in the parser (document is empty), so I think we could use it for a test.

Copy link
Member

@lopuhin lopuhin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks @Kebniss ! Left a comment regarding more granular exception handling in unification.

Copy link
Member

@lopuhin lopuhin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍 left a few minor comments

@Kebniss
Copy link
Contributor Author

Kebniss commented Dec 5, 2018

codecov fails because some exceptions are not tested, however I cannot come up with an input that is extracted ok but then fails when uniforming data

Copy link
Member

@lopuhin lopuhin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Kebniss looks good! I think it's expected that we can't test all exception code paths. Left one small comment, apart from that it's ready to merge 👍

Co-Authored-By: Kebniss <ludovica.gonella@gmail.com>
Copy link
Member

@lopuhin lopuhin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks @Kebniss 👍

@lopuhin lopuhin merged commit 3ab5592 into master Dec 5, 2018
@lopuhin lopuhin deleted the ignore-parsing-and-unification-exceptions branch December 5, 2018 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants