-
Notifications
You must be signed in to change notification settings - Fork 119
Added support for Open Graph arrays #138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## master #138 +/- ##
==========================================
+ Coverage 87.78% 88.06% +0.27%
==========================================
Files 11 11
Lines 475 486 +11
Branches 103 108 +5
==========================================
+ Hits 417 428 +11
Misses 52 52
Partials 6 6
Continue to review full report at Codecov.
|
lopuhin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR @ragnerok , some general feedback:
- could you please use 4 spaces for indentation, like in the rest of the project? Both are fine options but it's best to have the same setting through the whole project, and we'd like to stick to 4.
- could you please add tests which cover the new behavior?
|
@lopuhin I am sorry my text editor was set to 2 spaces, I'll fix it. I'll add a few test cases as well. |
* Fixed some style issues * Added testing for og_array
lopuhin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @ragnerok left some comments
* Removed list suffix
lopuhin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @ragnerok I think PR is in great shape and almost ready to get merged - please check remaining comments.
* Removed non_empty_props * Added test that checks duplicated and empty properties
lopuhin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thanks @ragnerok ! I think PR is ready to be merged, leaving it open for a bit in case someone else wants to review.
Co-authored-by: Adrián Chaves <adrian@chaves.io>
|
Thanks @ragnerok and thanks for review @Gallaecio 👍 |
Fixes #92
Once merged this would return Open Graph array when uniform is set True