Add "product" namespace support for opengraph #152
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is not a standard namespace (not mentioned in https://ogp.me/), but it's quite common in the wild, e.g. in a product page dataset where OG is present on ~35% of pages, this "product" namespace is present on 3.4% of pages, or ~10% of OG pages, and can often contain new information.
Codecov Report
@@ Coverage Diff @@
## master #152 +/- ##
=======================================
Coverage 89.23% 89.23%
=======================================
Files 12 12
Lines 539 539
Branches 122 122
=======================================
Hits 481 481
Misses 52 52
Partials 6 6
Continue to review full report at Codecov.
|
jakubwasikowski
approved these changes
Sep 7, 2020
Contributor
jakubwasikowski
left a comment
jakubwasikowski
left a comment
There was a problem hiding this comment.
Nice catch @lopuhin, I wasn't aware there is a namespace like that.
I don't have any suggestion re the PR. Looks great.
Approved 👍
Member
Author
|
Thanks @jakubwasikowski 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is not a standard namespace (not mentioned in https://ogp.me/), but it's quite common in the wild, e.g. in a product page dataset where OG is present on ~35% of pages, this "product" namespace is present on 3.4% of pages, or ~10% of OG pages, and can often contain new information.
tests/samples/misc/opengrapg_test.jsonis removed as this is a typo, correcttests/samples/misc/opengraph_test.jsonis also present.