can't set PLAYWRIGHT_DEFAULT_NAVIGATION_TIMEOUT to 0

[JustinQHu]

BY default, playwright has a timeout of 30 seconds for a lot of its behaviors, including:

You can set 0 to disable timeout for these actions in playwright, referring to Playwright API reference

Current code(line 68, scrape_playwright/hander.py) doesn't work when the value is 0:
self.default_navigation_timeout: Optional[int] = ( crawler.settings.getint("PLAYWRIGHT_DEFAULT_NAVIGATION_TIMEOUT") or None )

As you can see, then PLAYWRIGHT_DEFAULT_NAVIGATION_TIMEOUT is 0, the value of this expression is still None, for

0 or None

is still None in Python.

Rightnow, I just subclass ScrapyPlaywrightDownloadHandler to work around this issue.

Thank you.

[elacuesta]

You are correct, thanks for pointing it out.

[elacuesta]

Fixed in 6875f7c, released as v0.0.8. Thanks again for the report.