Skip to content

Conversation

@elacuesta
Copy link
Member

@elacuesta elacuesta commented Oct 1, 2021

Add a meta key to pass Page event handlers.

The idea and the initial implementation belong to @kalessin - thanks Martin!

@codecov
Copy link

codecov bot commented Oct 1, 2021

Codecov Report

Merging #28 (c2e9b88) into master (0724815) will not change coverage.
The diff coverage is 100.00%.

❗ Current head c2e9b88 differs from pull request most recent head 9eb2556. Consider uploading reports for the commit 9eb2556 to get more accurate results
Impacted file tree graph

@@            Coverage Diff            @@
##            master       #28   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            3         3           
  Lines          158       167    +9     
=========================================
+ Hits           158       167    +9     
Impacted Files Coverage Δ
scrapy_playwright/handler.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0724815...9eb2556. Read the comment docs.

Co-authored-by: Adrián Chaves <adrian@chaves.io>
Copy link

@kalessin kalessin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! thanks @elacuesta

@elacuesta elacuesta merged commit 4b8580f into master Oct 8, 2021
@elacuesta elacuesta deleted the event-handlers branch October 8, 2021 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants