Skip to content

Conversation

@Pandaaaa906
Copy link
Contributor

@Pandaaaa906 Pandaaaa906 commented Jan 28, 2022

control goto kwargs(like wait_until) from request.meta

yield Request(
    url, callback=self.parse,
    meta={
        "playwright": True, 
        "playwright_page_goto_kwargs": {
            'wait_until': 'domcontentloaded',
    }}
)

(edit) Tasks:

  • code
  • docs
  • tests

@elacuesta
Copy link
Member

elacuesta commented Mar 1, 2022

Looks good, thanks. Could you add docs and tests? I'm not sure why CI didn't run for this, there might be some problem in the configuration, I'll take a look.

@elacuesta elacuesta force-pushed the playwright_page_goto_kwargs branch from aff2905 to c6551bf Compare May 11, 2022 03:00
@codecov
Copy link

codecov bot commented May 11, 2022

Codecov Report

Merging #54 (e5a9731) into master (683ee5f) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master       #54   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            4         4           
  Lines          335       337    +2     
=========================================
+ Hits           335       337    +2     
Impacted Files Coverage Δ
scrapy_playwright/handler.py 100.00% <100.00%> (ø)

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@yswtrue
Copy link

yswtrue commented Jun 30, 2022

hope merge this feature

@elacuesta elacuesta mentioned this pull request Jul 11, 2022
@elacuesta elacuesta merged commit bd9bd95 into scrapy-plugins:master Jul 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants