Skip to content

Conversation

@elacuesta
Copy link
Member

  • Warn (and skip) if a value in playwright_page_coroutines is not a PageCoroutine object
  • Also accept non-awaitable calls (not strictly only coroutines anymore but hey, why not?)

@codecov
Copy link

codecov bot commented Mar 16, 2022

Codecov Report

Merging #69 (bcef5ef) into master (7e678ce) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master       #69   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            4         4           
  Lines          252       257    +5     
=========================================
+ Hits           252       257    +5     
Impacted Files Coverage Δ
scrapy_playwright/handler.py 100.00% <100.00%> (ø)

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@elacuesta elacuesta merged commit dc0666b into master Mar 16, 2022
@elacuesta elacuesta deleted the page-coroutine-checks branch March 16, 2022 04:20
@elacuesta elacuesta mentioned this pull request Mar 17, 2022
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants