Skip to content

Fixed#3553 --Genspider prepend http:// without checking it in the domain #3554

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Fixed#3553 --Genspider prepend http:// without checking it in the domain #3554

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5c40241
fixed genspider to pickup domain with http/https in start
nasirhjafri Dec 28, 2018
2ad1bc5
used re.split to avoid wrong domain name
nasirhjafri Jan 3, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions scrapy/commands/genspider.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
from __future__ import print_function
import os
import re
import shutil
import string

Expand Down Expand Up @@ -85,6 +86,7 @@ def run(self, args, opts):

def _genspider(self, module, name, domain, template_name, template_file):
"""Generate the spider module, based on the given template"""
domain = re.split('^https*://', domain)[-1]
tvars = {
'project_name': self.settings.get('BOT_NAME'),
'ProjectName': string_camelcase(self.settings.get('BOT_NAME')),
Expand Down