Skip to content

Fix #338: Fix set rotation style block #340

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 26, 2023
Merged

Fix #338: Fix set rotation style block #340

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/blocks/motionblocks.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,11 @@ void MotionBlocks::registerBlocks(IEngine *engine)

// Fields
engine->addField(this, "STYLE", STYLE);

// Field values
engine->addFieldValue(this, "left-right", LeftRight);
engine->addFieldValue(this, "don't rotate", DoNotRotate);
engine->addFieldValue(this, "all around", AllAround);
}

void MotionBlocks::compileMoveSteps(Compiler *compiler)
Expand Down
4 changes: 2 additions & 2 deletions src/blocks/motionblocks.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,8 +40,8 @@ class MotionBlocks : public IBlockSection
enum FieldValues
{
LeftRight,
AllAround,
DoNotRotate
DoNotRotate,
AllAround
};

std::string name() const override;
Expand Down
5 changes: 5 additions & 0 deletions test/blocks/motion_blocks_test.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,6 +140,11 @@ TEST_F(MotionBlocksTest, RegisterBlocks)
// Fields
EXPECT_CALL(m_engineMock, addField(m_section.get(), "STYLE", MotionBlocks::STYLE));

// Field values
EXPECT_CALL(m_engineMock, addFieldValue(m_section.get(), "left-right", MotionBlocks::LeftRight));
EXPECT_CALL(m_engineMock, addFieldValue(m_section.get(), "don't rotate", MotionBlocks::DoNotRotate));
EXPECT_CALL(m_engineMock, addFieldValue(m_section.get(), "all around", MotionBlocks::AllAround));

m_section->registerBlocks(&m_engineMock);
}

Expand Down