Skip to content

fix scratchcpp#317: the number of periods in a loop should be rounded #349

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 30, 2023
Merged

fix scratchcpp#317: the number of periods in a loop should be rounded #349

merged 2 commits into from
Nov 30, 2023

Conversation

@rdmsr
Copy link
Contributor

@rdmsr rdmsr commented Nov 28, 2023 •
edited by adazem009
Loading

Resolves: #317

@adazem009
Copy link
Contributor

adazem009 commented Nov 28, 2023

Thanks. It would be nice to have a unit test for this, but I think I'll do that myself after merging this pull request. You should also add Resolves: #317 to the description in future pull requests so that I can quickly check whether there's a pull request for a particular issue.

@adazem009 adazem009 merged commit 8f50de6 into scratchcpp:master Nov 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

The number of periods in a repeat loop should be rounded

2 participants

@rdmsr @adazem009