Skip to content

Conversation

@cwillisf
Copy link
Contributor

Resolves

Proposed Changes

Remove the json dependency

Reason for Changes

We don't seem to use it

I noticed that we don't seem to use it when I was checking #72 for possible trouble. Removing it entirely is even more secure than applying a security update ;)

@cwillisf cwillisf requested a review from a team as a code owner October 23, 2025 16:00
@github-actions
Copy link
Contributor

Test report for scratch-render

  1 files  ±0   55 suites  ±0   2s ⏱️ ±0s
209 tests ±0  209 ✅ ±0  0 💤 ±0  0 ❌ ±0 
279 runs  ±0  279 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 9028e55. ± Comparison against base commit f18087f.

@github-actions
Copy link
Contributor

Test report for scratch-svg-renderer

  1 files  ±0   60 suites  ±0   0s ⏱️ ±0s
124 tests ±0  124 ✅ ±0  0 💤 ±0  0 ❌ ±0 
276 runs  ±0  275 ✅ ±0  1 💤 ±0  0 ❌ ±0 

Results for commit 9028e55. ± Comparison against base commit f18087f.

@github-actions
Copy link
Contributor

Test report for scratch-vm

    1 files  ±0    770 suites  ±0   1m 5s ⏱️ ±0s
1 686 tests ±0  1 686 ✅ ±0   0 💤 ±0  0 ❌ ±0 
4 891 runs  ±0  4 861 ✅ ±0  30 💤 ±0  0 ❌ ±0 

Results for commit 9028e55. ± Comparison against base commit f18087f.

@github-actions
Copy link
Contributor

Test report for scratch-gui

  2 files  ±0   62 suites  ±0   10m 33s ⏱️ -7s
398 tests ±0  390 ✅ ±0  8 💤 ±0  0 ❌ ±0 
416 runs  ±0  408 ✅ ±0  8 💤 ±0  0 ❌ ±0 

Results for commit 9028e55. ± Comparison against base commit f18087f.

@cwillisf cwillisf added this pull request to the merge queue Oct 23, 2025
Merged via the queue into develop with commit 29e62ac Oct 23, 2025
20 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Oct 23, 2025
@cwillisf cwillisf deleted the remove-json branch October 23, 2025 16:34
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants