Skip to content

Conversation

@paulkaplan
Copy link
Contributor

This is a WIP, I'm working on getting the tests back

Resolves

What Github issue does this resolve (please include link)?

Resolves #1166

Proposed Changes

Describe what this Pull Request does

There are a fair number of changes here.

  • Update the asset button class to take in more options, totally redesigning the menu system.
  • Add new methods for adding surprise sprite/costume/backdrop/sounds.
  • Add new methods for adding empty sprites / backdrops, which also switch the tab focus to the paint editor.

There are things that will need refactoring, but we are going to wait until we can actually test this with people to learn more about the usability of these menus.

A refactor of the way tooltips are styled should also be considered with the next time we use tooltips, like the import modal work. For now, there is a fair bit of duplicated-ish CSS for controlling the tooltips.

Testing

I'm in the process of updating the tests.

@rschamp
Copy link
Contributor

rschamp commented Feb 26, 2018

Try it out: asset-menus

I'm a bot, not actually @rschamp!

This makes it possible to use on iOS/touch
@paulkaplan paulkaplan requested a review from rschamp February 26, 2018 16:21
@paulkaplan paulkaplan self-assigned this Feb 26, 2018
@paulkaplan paulkaplan removed the request for review from rschamp February 26, 2018 16:21
@paulkaplan paulkaplan merged commit 75f086e into develop Feb 26, 2018
@paulkaplan paulkaplan deleted the asset-menus branch February 26, 2018 16:30
@mrjacobbloom
Copy link

The wait time before closing solves all the problems I was worried about in terms of missing the buttons with the mouse, this feels really natural! Great job you guys!

The closing animation feels a little linear to me but that's no big

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Menu system for adding media (e.g. "Add Sprite")

4 participants