Monitor save load #3442
Closed
Monitor save load #3442
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…positioned or dragged, a new location should be recorded in the monitor data.
5 tasks
kchadha
force-pushed
the
monitor-save-load
branch
from
923a655 to
f433465
Compare
Contributor
Author
|
Tests are currently failing because of the dependency on the scratch-vm PR. |
Contributor
|
Marking this as blocked since the VM one is in limbo scratchfoundation/scratch-vm#1686 |
Contributor
Author
|
Closing this until I can come back to it at a later time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Add ability to save and load monitors in 3.0 projects.
Monitors retain position and mode across save and load.
Test Coverage
Manual testing.
Test instructions in scratchfoundation/scratch-vm#1686.
Testing branch: https://llk.github.io/scratch-gui/monitors/
Related PRs
This PR is dependent on scratchfoundation/scratch-vm#1686. The VM PR should be merged first.
Browser Coverage
Check the OS/browser combinations tested (At least 2)
Mac
Windows
Chromebook
iPad
Android Tablet