Allow sprites named stage

[kchadha]

Resolves #49 which was causing save/load failures for 2.0 and 3.0 projects.

[kchadha]

@picklesrus and I discovered an issue with saving/loading a project from 2.0 where a sprite was named 'stage'. Turns out that we can reproduce this error (completely separate from 2.0) where naming a sprite 'stage' or 'Stage' in the 3.0 editor does not allow save/load because the sb3 fails validation. This fix will need to be deployed to scratch-projects and scratch-analysis (in addition to being updated in scratch-vm).

[kchadha]

Hmmm for some reason commit lint is failing on travis (but running npm run commitmsg locally is not failing for me.

It looks like this is a problem with the node version. Switching to node 11 locally and running npm run commitmsg gives me the same error I see in the travis build...

[joker314]

Question about _stage_

[joker314]

Should validation not fail if you try to name a sprite _stage_, or is that handled elsewhere?

Suggested change

	"type": "string"
	"type": "string"
	"not": {"enum": ["_stage_"]}

[kchadha]

@joker314, good catch! It looks like both the 2.0 and 3.0 editors prevent renaming a sprite to _stage_ so that should be included in the validation.

[thisandagain]

Thanks for catching that @joker314.

[thisandagain]

This looks good to me. It would be nice to test the error condition with a test fixture that has a sprite called _stage_, but other than that I think this is good to go.

[thisandagain]

Thanks for catching that @joker314.

[kchadha]

@thisandagain, added the fix that @joker314 suggested and added a test fixture in the invalid sub directory for it.

I also updated the commitlint package (verifying locally that it works with both node 8 and 11), so now the build is not failing on travis anymore.

[kchadha]

🎉 This PR is included in version 4.3.3 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀