Clear the pen layer when runtime dispose happens. #1815
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kchadha
reviewed
Dec 4, 2018
kchadha
suggested changes
Dec 4, 2018
Contributor
kchadha
left a comment
kchadha
left a comment
There was a problem hiding this comment.
Failing test, but after that LG.
Co-Authored-By: paulkaplan <pkaplan@media.mit.edu>
Contributor
Author
|
Thanks for that! I was being too hasty! Included your suggestion. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves
What Github issue does this resolve (please include link)?
Resolves scratchfoundation/scratch-gui#1850
Proposed Changes
Describe what this Pull Request does
Add a RUNTIME_DISPOSED event that the pen extension listens for and clears the pen layer when it occurs.
No attempt is made in this PR to unload the extension blocks or anything like that.
Repro that now works: