Fix variable characters #1973
Merged
Fix variable characters #1973
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves
Work towards #1077.
Proposed Changes
Thanks to @picklesrus for pairing on this!
Fix issues with importing projects from scratch 2 (or even scratch 3 projects that were originally from 2.0) that have variables or lists with special characters in their names. When importing a 2.0 project, we were adding the user defined variable name (which could include special xml-unsafe chars) to the variable id. This was preventing blocks referencing variables with these special characters from showing up in the project (or in the toolbox).
Known Issues:
Test Coverage
Added tests!