Skip to content
This repository was archived by the owner on Aug 12, 2022. It is now read-only.

Conversation

@benjiwheeler
Copy link
Contributor

@benjiwheeler benjiwheeler commented Apr 14, 2020

Resolves https://github.com/LLK/scratchjr-private/issues/558

Changes

  • Revises ios and android code to send the event's "action" field as its Firebase Analytics event type (instead of every event having the same type, VIEW_ITEM)
  • Adds the following analytics events:
    • paint_editor_close
    • paint_editor_open
    • full_screen_exited
    • add_text
    • add_scene
    • delete_scene
    • show_grid
    • hide_grid
    • text_sprite_open
    • text_sprite_close
    • text_sprite_create
    • start_recording, stop_recording
    • record_dialog_open
    • record_dialog_close

Copy link
Contributor

@chrisgarrity chrisgarrity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I ran this and it all looks pretty good. There are just a few things I'm wondering about.

When you open a project it always calls hide-grid, and if there are any text sprites, it calls create_text_sprite. It would be good to figure out how to suppress these calls during project initialization.

Also, now that we have open/close paint, text, recording... I'm noticing that we don't log open/close the editor. That is, we have create project and edit existing, but we don't log when you return to the lobby. Let's talk to decide what to do about these.

@benjiwheeler
Copy link
Contributor Author

When you open a project it always calls hide-grid, and if there are any text sprites, it calls create_text_sprite. It would be good to figure out how to suppress these calls during project initialization.

OK, take a look at my changes

ScratchJr.stopStripsFromTop(e);
ScratchJr.unfocus(e);
ScratchJr.saveProject(e, ScratchJr.flippage);
iOS.analyticsEvent('editor', 'project_editor_close');
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested this and it seems to only be called when you click the home button while within the project editor. The function name "flip" is a little confusing

UI.creatTopBarClicky(div, 'resetall', 'resetall', UI.resetAllSprites);
UI.creatTopBarClicky(div, 'full', 'fullscreen', ScratchJr.fullScreen);
UI.toggleGrid(true);
UI.setShowGrid(false);
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that I changed this function to be more clear, and to better distinguish it from switchGrid()

@benjiwheeler benjiwheeler removed their assignment Apr 20, 2020
@benjiwheeler benjiwheeler modified the milestones: April 2020, May 2020 May 1, 2020
@chrisgarrity chrisgarrity modified the milestones: May 2020, June 2020 Jun 8, 2020
@chrisgarrity
Copy link
Contributor

@benjiwheeler I had a conversation with Aim yesterday, and one of the most critical things they look at is which blocks get used. Given the UI provided by Analytics, it's easiest to count based on event (rather than a parameter of an event). So instead of event: 'new_block' with the block name as parameter, it would be good to have the event be 'new_block_' + block_name. Then we'll generate events like new_block_forward and new_block_shrink

@benjiwheeler
Copy link
Contributor Author

@chrisgarrity Could we maybe merge this PR with its previous scope, and then treat the blocks analytics as a separate issue?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants