-
Notifications
You must be signed in to change notification settings - Fork 326
Add more analytics events, and use action as event type #260
Add more analytics events, and use action as event type #260
Conversation
chrisgarrity
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I ran this and it all looks pretty good. There are just a few things I'm wondering about.
When you open a project it always calls hide-grid, and if there are any text sprites, it calls create_text_sprite. It would be good to figure out how to suppress these calls during project initialization.
Also, now that we have open/close paint, text, recording... I'm noticing that we don't log open/close the editor. That is, we have create project and edit existing, but we don't log when you return to the lobby. Let's talk to decide what to do about these.
OK, take a look at my changes |
| ScratchJr.stopStripsFromTop(e); | ||
| ScratchJr.unfocus(e); | ||
| ScratchJr.saveProject(e, ScratchJr.flippage); | ||
| iOS.analyticsEvent('editor', 'project_editor_close'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested this and it seems to only be called when you click the home button while within the project editor. The function name "flip" is a little confusing
| UI.creatTopBarClicky(div, 'resetall', 'resetall', UI.resetAllSprites); | ||
| UI.creatTopBarClicky(div, 'full', 'fullscreen', ScratchJr.fullScreen); | ||
| UI.toggleGrid(true); | ||
| UI.setShowGrid(false); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note that I changed this function to be more clear, and to better distinguish it from switchGrid()
|
@benjiwheeler I had a conversation with Aim yesterday, and one of the most critical things they look at is which blocks get used. Given the UI provided by Analytics, it's easiest to count based on event (rather than a parameter of an event). So instead of event: 'new_block' with the block name as parameter, it would be good to have the event be |
|
@chrisgarrity Could we maybe merge this PR with its previous scope, and then treat the blocks analytics as a separate issue? |
Resolves https://github.com/LLK/scratchjr-private/issues/558
Changes