Issue/274 wkwebview rebase #291
Conversation
Upgrade webview to WKWebView with many thanks to @yueyuzhao * Need to debug a problem saving thumbnails on iOS 9.3.5 * Needs much more testing
|
Hi @chrisgarrity , thanks for your hard work and your message. |
|
I've been testing this on Android and XCode, and everything seems to work well so far! |
| - (void) callback:(NSString *)res { | ||
| NSString *js = nil; | ||
| if ([res hasPrefix:@"["] || [res hasPrefix:@"{"]) { | ||
| js = [NSString stringWithFormat:@"iOS.resolve('%@', %@);", self.callId, res]; |
There was a problem hiding this comment.
So am I right in understanding that we either expect res to be like:
returnStr
- or -
{someKey: "someVal", someOtherKey: ["str1", "str2", "str3"]}
?
What I wonder is, when there are arrays/objects within an array/object, are we sure the quotes will be right?
There was a problem hiding this comment.
I think there's one other option:
["someVal", "anotherVal"]
but as far as I can tell, the only function that returns an array is the dir method in IO.m, and I cannot find any places that is used.
In general, I think there's a bigger refactor here where all data passed between javascript and native gets converted to string/base64 encoded consistently. Right now we're relying on the evaluateJavaScript to do the right thing.
|
@yueyuzhao we're running into an issue where the scratchjr HTML, loaded from the app bundle directory, cannot display assets (svg, png) that have been saved in the Documents folder. This appears to be a security restriction for the wekwebview. BTW, it works fine in the simulator, it only stops working when you run it on an actual iPad. We're exploring different ways to solve it, but since you submitted the original PR, I wanted to give you a head's up on what's taking so long. |
|
Hi @chrisgarrity , there need a little change in the |
|
My computer was broken several days ago, and I'm setting up my developing environments. Once I confirmed that |
Hi @chrisgarrity , changing these lines in |
|
@chrisgarrity , sorry for my testing not covering this. I fixed this issue on my computer, but It's late in China, I will submit a merge request tomorrow after more tests. |
|
Hi @chrisgarrity , this is the patch file that fixes assets displaying issue. Tests:
|
many thanks @yueyuzhao
Don’t pass NSNulls to Firebase. Paramaters must be string or integer, so use ‘undefined’ to match current values.
|
LGTM! Tested on Android 5.0.2 tablet and iOS 9.x tablet. |
Resolves
Fixes #274
(Replaces https://github.com/LLK/scratchjr/pull/288 which github mysteriously insisted had merge conflicts, but we couldn't actually see any)
Proposed Changes
Many thanks to @yueyuzhao for the first version of upgrading to WKWebview in https://github.com/LLK/scratchjr/pull/283
Reason for Changes
UIWebView is deprecated and new versions that use it are no longer accepted by the App store.
Testing
This replaces the interface between javascript and iOS native calls. It will require extensive manual testing (on iOS and Android to verify that changes did not break anything)