Skip to content
This repository was archived by the owner on Aug 12, 2022. It is now read-only.

Conversation

@benjiwheeler
Copy link
Contributor

Resolves

Resolves https://github.com/LLK/scratchjr/issues/315

Proposed Changes

fixes buzz bug when initialOptions missing from settings. Previously, the nextUnansweredQuestion() function would return [] if no questions were found. But [] is truthy, not falsy, and index.js would think there is a question to ask!

Copy link
Contributor

@chrisgarrity chrisgarrity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@benjiwheeler benjiwheeler merged commit ddcd876 into develop Sep 14, 2020
@benjiwheeler benjiwheeler deleted the fix-buzz-on-missing-settings branch September 14, 2020 14:45
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Allow missing initialOptions section in settings.json

3 participants