This repository was archived by the owner on Aug 12, 2022. It is now read-only.
Add new languages to menu #317
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
LGTM, tested on android emulator |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #252
Adds Greek, Norwegian, Polish, Brazilian Portuguese, and Turkish to the list of languages. Chinese (traditional and simplified) had already been added at some point. PRs from transifex updated the existing translations.
Note: the list of languages no longer fits on one screen. It is scrollable, so people can get to all the languages, but they may not realize there are additional languages that aren't visible. At some point we should redesign the language preferences (#147 ).