fix: generate deploy keys to per-call temp path with cleanup#258
Merged
Conversation
The deploy-key generator wrote the RSA private key to a fixed path inside the package install directory with no guaranteed cleanup if the subsequent GitHub API call failed. Generate each key into a unique directory under os.tmpdir() and remove the directory in a try/finally regardless of outcome. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
DekusDenial
approved these changes
May 29, 2026
|
🎉 This PR is included in version 14.6.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
generateDeployKeynow writes the RSA private key into a unique directory created viafs.promises.mkdtemp(os.tmpdir() + '/sd-deploykey-')instead of the predictable in-module${__dirname}/keys_rsapath.try/finallyso the temp directory is removed regardless of outcome.Test plan
generateDeployKeycontinue to pass.npm run lintandnpm testare green.