PE-939: AWS Secrets Manager #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Maks-D
reviewed
May 19, 2022
src/test/scala/com/databricks/labs/overwatch/pipeline/TransformFunctionsTest.scala
Show resolved
Hide resolved
src/main/scala/com/databricks/labs/overwatch/ParamDeserializer.scala
Outdated
Show resolved
Hide resolved
src/main/scala/com/databricks/labs/overwatch/ParamDeserializer.scala
Outdated
Show resolved
Hide resolved
src/main/scala/com/databricks/labs/overwatch/pipeline/Initializer.scala
Outdated
Show resolved
Hide resolved
src/main/scala/com/databricks/labs/overwatch/pipeline/Module.scala
Outdated
Show resolved
Hide resolved
src/main/scala/com/databricks/labs/overwatch/pipeline/Module.scala
Outdated
Show resolved
Hide resolved
src/main/scala/com/databricks/labs/overwatch/utils/SecretTools.scala
Outdated
Show resolved
Hide resolved
Maks-D
reviewed
May 20, 2022
src/main/scala/com/databricks/labs/overwatch/ParamDeserializer.scala
Outdated
Show resolved
Hide resolved
src/main/scala/com/databricks/labs/overwatch/ParamDeserializer.scala
Outdated
Show resolved
Hide resolved
src/main/scala/com/databricks/labs/overwatch/pipeline/Initializer.scala
Outdated
Show resolved
Hide resolved
src/main/scala/com/databricks/labs/overwatch/pipeline/Initializer.scala
Outdated
Show resolved
Hide resolved
Maks-D
approved these changes
May 20, 2022
shtusha
approved these changes
May 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add possibility to work with AWS Secrets Manager
Parallel PR to upstream - databrickslabs#379
Note: to keep backward compatibility and to comply with target report table structure for keys (two string columns scope and key) the AWS secret saving to the report table aligned accordingly
End-to-end tests: through notebook with new overwatch jar attached - https://scribd-ad-hoc.cloud.databricks.com/?o=7155453715695022#notebook/2705398767369691/command/2705398767369705