Skip to content

Add delete_in argument #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
terranisu merged 2 commits into from
Apr 5, 2024
Merged

Add delete_in argument #21

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
555d9db
feat: Add delete_in argument
terranisu Apr 4, 2024
483985a
chore: Update README
terranisu Apr 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 12 additions & 6 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ A module to create application secrets stored in [AWS Secrets Manager](https://a
* [Cross-account secrets](#cross-account-secrets)
* [Inputs](#inputs)
* [Secrets](#secrets)
* [Recovery window](#recovery-window)
* [Outputs](#outputs)
* [Release](#release)
* [Maintainers](#maintainers)
Expand Down Expand Up @@ -210,12 +211,13 @@ module "user" {

## Inputs

| Name | Description | Type | Default | Required |
|:-------------|:---------------------------------------|:-------------|:------------|:---------|
| `app_name` | Application name | string | `null` | yes |
| `aws_region` | AWS region | string | `us-east-2` | no |
| `secrets` | List of objects of [secrets](#secrets) | list(object) | `null` | yes |
| `tags` | Key-value map of tags | map(string) | `{}` | no |
| Name | Description | Type | Default | Required |
|:-------------|:------------------------------------------------------------------|:-------------|:------------|:---------|
| `app_name` | Application name | string | `null` | yes |
| `aws_region` | AWS region | string | `us-east-2` | no |
| `secrets` | List of objects of [secrets](#secrets) | list(object) | `null` | yes |
| `delete_in` | [Number of days](#recovery-window) to wait before secret deletion | number | `30` | no |
| `tags` | Key-value map of tags | map(string) | `{}` | no |

### Secrets

Expand All @@ -225,6 +227,10 @@ module "user" {
| `value` | Secret value | string | `null` |
| `allowed_arns` | List of principal ARNs that have access to the secret | list | `null` |

### Recovery window

Number of days that AWS Secrets Manager waits before it can delete the secret. This value can be `0` to force deletion without recovery or range from `7` to `30` days. The default value is `30`.

## Outputs

| Name | Description | Sensitive |
Expand Down
2 changes: 2 additions & 0 deletions main.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,8 @@ resource "aws_secretsmanager_secret" "app" {

policy = lookup(local.arns, each.key, null) == null ? null : data.aws_iam_policy_document.access[each.key].json

recovery_window_in_days = var.delete_in

tags = merge(var.tags, { "service" = var.app_name })
}

Expand Down
12 changes: 12 additions & 0 deletions variables.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,18 @@ variable "secrets" {
)
}

variable "delete_in" {
description = "Number of days to wait before secret deletion"
type = number

default = 30

validation {
condition = var.delete_in == 0 || contains(range(7, 30), var.delete_in)
error_message = "The delete_in value must be 0 or between 7 and 30."
}
}

variable "tags" {
description = "Key-value map of tags"
type = map(string)
Expand Down