Skip to content

Conversation

@terranisu
Copy link
Member

@terranisu terranisu commented Apr 5, 2024

Description

A follow-up PR to #21 to fix the validation failure when the delete_in value is set to the default value:

│ Error: Invalid value for variable
│ 
│   on .terraform/modules/app_go_chassis.secrets/variables.tf line 24:24: variable "delete_in" {
│ 
│ The delete_in value must be 0 or between 7 and 30.

Testing considerations

The fix is tested in on of our root modules

Checklist

  • Prefixed the PR title with the JIRA ticket code
  • Performed simple, atomic commits with good commit messages
  • Verified that the commit history is linear and commits are squashed as necessary
  • Thoroughly tested the changes in development and/or staging
  • Updated the README.md as necessary

Related links

@terranisu terranisu self-assigned this Apr 5, 2024
@terranisu terranisu marked this pull request as ready for review April 5, 2024 10:57
@terranisu terranisu requested a review from a team as a code owner April 5, 2024 10:57
Copy link
Contributor

@Neurostep Neurostep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@terranisu terranisu merged commit ad37f47 into main Apr 5, 2024
@terranisu terranisu deleted the vadimka/fix-reconvery-window-range branch April 5, 2024 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants