Skip to content

enabling schema evolution for oxbow controlled tables #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kuntalkumarbasu merged 1 commit into from
Aug 14, 2024
Merged

enabling schema evolution for oxbow controlled tables #36

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion main.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,6 +82,8 @@ resource "aws_kinesis_firehose_delivery_stream" "this_kinesis" {
locals {
oxbow_lambda_unwrap_sns_event = var.enable_group_events == true ? {} : var.sns_topic_arn == "" ? {} : { UNWRAP_SNS_ENVELOPE = true }
group_eventlambda_unwrap_sns_event = var.sns_topic_arn == "" ? {} : { UNWRAP_SNS_ENVELOPE = true }
oxbow_lambda_schema_evolution = var.enable_schema_evolution == false ? {} : { SCHEMA_EVOLUTION = true }

}

resource "aws_lambda_function" "this_lambda" {
Expand All @@ -101,7 +103,7 @@ resource "aws_lambda_function" "this_lambda" {
variables = merge({
AWS_S3_LOCKING_PROVIDER = var.aws_s3_locking_provider
RUST_LOG = "deltalake=${var.rust_log_deltalake_debug_level},oxbow=${var.rust_log_oxbow_debug_level}"
DYNAMO_LOCK_TABLE_NAME = var.dynamodb_table_name }, local.oxbow_lambda_unwrap_sns_event)
DYNAMO_LOCK_TABLE_NAME = var.dynamodb_table_name }, local.oxbow_lambda_unwrap_sns_event, local.oxbow_lambda_schema_evolution)
Copy link
Contributor

@HamiltonHord HamiltonHord Aug 14, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
DYNAMO_LOCK_TABLE_NAME = var.dynamodb_table_name }, local.oxbow_lambda_unwrap_sns_event, local.oxbow_lambda_schema_evolution)
DYNAMO_LOCK_TABLE_NAME = var.dynamodb_table_name
},
local.oxbow_lambda_unwrap_sns_event,
local.oxbow_lambda_schema_evolution
)

}
tags = var.tags
}
Expand Down
6 changes: 6 additions & 0 deletions variables.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -304,6 +304,12 @@ variable "enable_glue_create" {
default = false
}

variable "enable_schema_evolution" {
type = bool
description = "Whether to turn on schema evolution"
default = true
}

variable "glue_create_config" {
type = object({
athena_workgroup_name = string // Name of AWS Athena workgroup
Expand Down