-
Notifications
You must be signed in to change notification settings - Fork 93
Add instrumentation test job to android_ci.yml #423
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add instrumentation test job to android_ci.yml #423
Conversation
Thank you for the pull request! ❤️The Scribe-Android team will do our best to address your contribution as soon as we can. If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the |
Maintainer ChecklistThe following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :) |
|
Hello @angrezichatterbox , I have a PR here to add GH Actions for android instrumented tests. for now, only the license check action is running! Can you please help me check/verify that is PR is valid? cc: @andrewtavis |
|
Hi @angrezichatterbox , so I fixed the issue. It was a typo issue and improper referencing. I await your feedback now. cc: @andrewtavis |
|
Hi @angrezichatterbox, so I fixed another case where the Emulator fails to start. This was causing the test cases to fail after I merged main into this branch. If you need any explanation on my script, please ask, I will answer appropriately. cc: @andrewtavis |
|
Let me try running this workflow using |
angrezichatterbox
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me @DeleMike. You tried running it by creating a PR for yourself in your fork right. I couldn't run using act due to permission issue but looks fine.
|
Yes, I did. And it worked well! :) Wanted you to confirm that this is what you expected. |
andrewtavis
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My commit was minor edits to standardize the names of the stages here :) Thanks so much for the quick work here, @DeleMike! 😊😊
|
Oh thank you! |
Contributor checklist
./gradlew lintKotlin detekt testcommand as directed in the testing section of the contributing guideDescription
Resolves #422
This PR adds a new
instrumentation_testjob to.github/workflows/android_ci.ymlto run instrumentation tests using./gradlew connectedAndroidTest.Testing:
./gradlew connectedAndroidTestlocally to confirm tests pass.app/build/reports/androidTests/connected/.Notes:
app/src/androidTest.