Skip to content

Conversation

@DeleMike
Copy link
Collaborator

@DeleMike DeleMike commented Jun 11, 2025

Contributor checklist


Description

Resolves #422

This PR adds a new instrumentation_test job to .github/workflows/android_ci.yml to run instrumentation tests using ./gradlew connectedAndroidTest.

Testing:

  • Ran ./gradlew connectedAndroidTest locally to confirm tests pass.
  • Verified test reports in app/build/reports/androidTests/connected/.

Notes:

  • Assumed tests exist in app/src/androidTest.

@github-actions
Copy link

Thank you for the pull request! ❤️

The Scribe-Android team will do our best to address your contribution as soon as we can. If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and Android rooms once you're in. Also consider attending our bi-weekly Saturday dev syncs. It'd be great to meet you 😊

@github-actions
Copy link

github-actions bot commented Jun 11, 2025

Maintainer Checklist

The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)

  • The linting and formatting workflows within the PR checks do not indicate new errors in the files changed

  • The CHANGELOG has been updated with a description of the changes for the upcoming release and the corresponding issue (if necessary)

@DeleMike
Copy link
Collaborator Author

Hello @angrezichatterbox , I have a PR here to add GH Actions for android instrumented tests.

for now, only the license check action is running!

Can you please help me check/verify that is PR is valid?

cc: @andrewtavis

@DeleMike
Copy link
Collaborator Author

Hi @angrezichatterbox , so I fixed the issue. It was a typo issue and improper referencing.

I await your feedback now.

cc: @andrewtavis

@DeleMike
Copy link
Collaborator Author

Hi @angrezichatterbox, so I fixed another case where the Emulator fails to start. This was causing the test cases to fail after I merged main into this branch. If you need any explanation on my script, please ask, I will answer appropriately.

cc: @andrewtavis

@angrezichatterbox
Copy link
Member

Let me try running this workflow using act locally and would sent in the review later today :)

Copy link
Member

@angrezichatterbox angrezichatterbox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me @DeleMike. You tried running it by creating a PR for yourself in your fork right. I couldn't run using act due to permission issue but looks fine.

@DeleMike
Copy link
Collaborator Author

Yes, I did. And it worked well! :)

Wanted you to confirm that this is what you expected.

Copy link
Member

@andrewtavis andrewtavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My commit was minor edits to standardize the names of the stages here :) Thanks so much for the quick work here, @DeleMike! 😊😊

@andrewtavis andrewtavis merged commit 8e62f77 into scribe-org:main Jun 14, 2025
6 checks passed
@DeleMike
Copy link
Collaborator Author

Oh thank you! ☺️
Most likely my IDE settings.

@DeleMike DeleMike deleted the feat/add-android-instrumentation-tests-for-ci branch June 15, 2025 07:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add Instrumentation Tests to GitHub Actions Workflow

3 participants