Version comparison fails due to inconsistent version string formats

[axif0]

Terms

• I have searched all open bug reports
• I agree to follow Scribe-Data's Code of Conduct

Behavior

The version comparison in get_version_message() incorrectly reports available updates when local and latest versions are the same, due to mismatched string formats ("v" prefix and "Scribe-Data" prefix inconsistencies).

Contribution

Happy to review a PR when one's open and support with answers to any questions! 😊

[andrewtavis]

Thanks for opening this, @axif0! Great to see that you're testing so much of the package :) :)

[harikrishnatp]

I've identified where it's going wrong. In the get_version_message() function, the value fetched from Github only has Scribe-Data without the v prefix while the value stored in local_version has Scribe-Data with a v. I could just standardise the version by removing Scribe-Data prefix from both for comparing and then adding v.

Also, the pip scribe-data --upgrade command is wrong, I fixed that as well

@axif0, @andrewtavis could you guys let me know about your thoughts on this ? I'll send a PR right away if this approach seems good!

[harikrishnatp]

@axif0 Yeah, sure

[axif0]

Great @harikrishnatp ~ looking forward to see the PR.. 😊

[andrewtavis]

Closed by #535 🚀 Really appreciate the two great contributions to the project so far, @harikrishnatp 😊 Hope we can work with you more! Please let us know if you'd have interest in another issue here or in another Scribe project ✨