[MV2] 翻译更新，package 更新 #916
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
感谢🙏，我这两天更新到firefox去 |
Contributor
There was a problem hiding this comment.
Pull Request Overview
这个PR主要进行了以下改进：
- 修复了API类型定义中的拼写错误（minetype → mimetype）
- 添加了文件名清理功能以处理非法字符
- 增强了脚本验证逻辑，包括@grant冲突检测和元数据重复检测
- 将错误消息国际化（i18n）
- 更新了UI文本和翻译
- 升级了多个依赖包版本
Reviewed Changes
Copilot reviewed 17 out of 19 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| src/types/scriptcat.d.ts | 修复GM_setClipboard API中的拼写错误 |
| src/runtime/content/gm_api.ts | 同步修复API实现中的拼写错误 |
| src/runtime/background/gm_api.ts | 添加文件名清理功能到下载API |
| src/pkg/utils/utils.ts | 新增cleanFileName函数 |
| src/pkg/utils/script.ts | 添加脚本验证、i18n错误消息、编辑器选项 |
| src/template/normal.tpl | 添加默认元数据标签 |
| src/pages/options/routes/script/ScriptEditor.tsx | 传递编辑器标志 |
| src/pages/options/routes/ScriptList.tsx | UI改进和拖拽限制 |
| src/locales/* | 统一翻译键名并添加新错误消息 |
| package.json | 升级依赖包版本 |
Comment on lines
+201
to
+202
| const hasGrantConflict = (metadata: SCMetadata | undefined | null) => | ||
| metadata?.grant?.includes("none") && metadata?.grant?.some((s: string) => s.startsWith("GM")); |
| for (const list of Object.values(metadata)) { | ||
| if (list && new Set(list).size !== list.length) return true; | ||
| } | ||
| } |
There was a problem hiding this comment.
函数缺少显式返回false。虽然JavaScript会隐式返回undefined（等同于false），但最佳实践应在末尾显式返回false以提高代码可读性和意图明确性。
Suggested change
| } | |
| } | |
| return false; |
Collaborator
Author
There was a problem hiding this comment.
mv3合并了没写 return false; 的。不是好习惯但暂时先这样
Member
|
build没通过，我觉得还是不要更新package了，免得又出些其它岔子 |
Member
|
只是lint问题，我处理了，不过确实感觉不更新package的好，不过你处理了，就这样吧 |
Collaborator
Author
有build 跟test过的 MV2 版本号是 跟随MV3的 package 版本号 |
Collaborator
Author
定期手动更新一下吧 |
Member
主要是担心出现其它问题啦 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
毕竟还是有人在用 Firefox，需要更新一下 MV2
先更新一部份
之后再把 UI 的部份 和 GM API 的 GM.setValue/GM.getValue/GM.listValue ... 更新一下
有 npm run test 和 npm run build 过。可以在 Firefox 运行
85b48e2
2518722
fb3d132
5089b2a