🔥 Fix filtering with null values #83
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robertvansteen
approved these changes
Nov 21, 2018
Codecov Report
@@ Coverage Diff @@
## master #83 +/- ##
============================================
+ Coverage 83.96% 84.12% +0.15%
- Complexity 640 642 +2
============================================
Files 75 75
Lines 1858 1864 +6
============================================
+ Hits 1560 1568 +8
+ Misses 298 296 -2
Continue to review full report at Codecov.
|
erikgaal
added a commit
that referenced
this pull request
Nov 22, 2018
* Add regression test for filtering with nullable value * Add nullableItems api to fields and fix the collection filter type (cherry picked from commit e3317af)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.