Skip to content

Conversation

@erikgaal
Copy link
Contributor

No description provided.

@erikgaal erikgaal added the in progress 🚧 PR that is still in progress and is not ready to be reviewed and/or merged yet. label Dec 17, 2018
@codecov
Copy link

codecov bot commented Dec 18, 2018

Codecov Report

Merging #87 into master will increase coverage by 0.07%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #87      +/-   ##
============================================
+ Coverage     84.39%   84.47%   +0.07%     
- Complexity      647      649       +2     
============================================
  Files            75       75              
  Lines          1878     1887       +9     
============================================
+ Hits           1585     1594       +9     
  Misses          293      293
Impacted Files Coverage Δ Complexity Δ
src/Mutations/AttachPivotMutation.php 96.29% <100%> (-0.38%) 6 <0> (-1)
src/Eloquent/Concerns/InteractsWithRelations.php 87.22% <100%> (+0.91%) 53 <5> (+3) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4c71e53...343c8e1. Read the comment docs.

@robertvansteen robertvansteen removed the in progress 🚧 PR that is still in progress and is not ready to be reviewed and/or merged yet. label Dec 18, 2018
@robertvansteen robertvansteen self-requested a review December 18, 2018 16:48
@robertvansteen robertvansteen merged commit 2e41f0c into master Dec 18, 2018
@robertvansteen robertvansteen deleted the hotfix/pivot-relation-data branch December 18, 2018 16:49
erikgaal added a commit that referenced this pull request Dec 18, 2018
* Add regression test for setting relation via pivot field

* Implement relational pivot data

* Add another test for creating pivot data

(cherry picked from commit 2e41f0c)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants