fix: add sload/sstore witness when calculating dynamic gas

[colinlyguo]

1. Purpose or design rationale of this PR

This PR gets the witness of SLOAD and SSTOREimmediately before calculating their dynamic gas, to align with reth's witness implementation.

Another place that needs to change for SLOAD witness loading is when calculating the gas cost after Frontier and before EIP-2929. Frontier gas cost simply uses params.SloadGasFrontier (i.e. 50 gas), so changing the gas cost there might affect code cleanliness. Usually, this won't be a problem because EIP-2929 is enabled by default, thus leaving adding SLOAD witness before EIP-2929 as a TODO.

2. PR title

Your PR title must follow conventional commits (as we are doing squash merge for each PR), so it must start with one of the following types:

• fix: A bug fix

3. Deployment tag versioning

Has the version in params/version.go been updated?

• Yes

4. Breaking change label

Does this PR have the breaking-change label?

• This PR is not a breaking change

Summary by CodeRabbit

Summary by CodeRabbit

• Refactor

  • Improved the sequence of operations for state retrieval and gas calculations in multiple functions.

• Chore

  • Incremented the patch version to reflect the latest release (VersionPatch updated from 29 to 30).

[coderabbitai]

Walkthrough

The changes involve modifications across three files. In the core module, the makeGasSStoreFunc and gasSLoadEIP2929 functions are updated to reorder logic, add comments, and adjust state retrieval for SSTORE operations. The gasSStore and gasSStoreEIP2200 functions now include a new line to retrieve the original state before gas checks. Additionally, the patch version constant in the parameters module is incremented from 29 to 30.

Changes

File(s)	Change Summary
core/vm/operations_acl.go	Reordered logic and added comments in makeGasSStoreFunc and gasSLoadEIP2929; added a line to retrieve the witness for SSTORE, with a TODO for gas cost.
core/vm/gas_table.go	Added a line to retrieve the original state in gasSStore and gasSStoreEIP2200; reordered gas checks to follow state retrieval.
params/version.go	Updated the VersionPatch constant value from 29 to 30.

Suggested labels

bump-version

Suggested reviewers

• georgehao
• Thegaram
• jonastheis

Poem

Oh, nimble paws tap keys with delight,
A new state call hops into sight.
With a version bumped ever so bright,
Codes and carrots align just right.
I, a rabbit in the code meadow, rejoice tonight!

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 5f5a86b and 9d46456.

📒 Files selected for processing (1)

• core/vm/operations_acl.go (2 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

• core/vm/operations_acl.go

⏰ Context from checks skipped due to timeout of 90000ms (1)

• GitHub Check: Analyze (go)

---

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[lightsing]

LGTM