-
Notifications
You must be signed in to change notification settings - Fork 284
fix devnet tx replay issue #1254
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughThis PR adjusts the minimum base fee in CalcBaseFee from 10000000 wei to 1 wei for the Clique shadow fork devnet scenario, and updates eight Go module dependencies in the export-headers-toolkit to newer versions. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes
Possibly related PRs
Suggested reviewers
Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
rollup/missing_header_fields/export-headers-toolkit/go.sumis excluded by!**/*.sum
📒 Files selected for processing (2)
consensus/misc/eip1559.go(1 hunks)rollup/missing_header_fields/export-headers-toolkit/go.mod(2 hunks)
🧰 Additional context used
🪛 OSV Scanner (2.2.4)
rollup/missing_header_fields/export-headers-toolkit/go.mod
[HIGH] 18-18: github.com/consensys/gnark-crypto 0.16.0: Unchecked memory allocation during vector deserialization in github.com/consensys/gnark-crypto
(GO-2025-4087)
[HIGH] 18-18: github.com/consensys/gnark-crypto 0.16.0: gnark-crypto allows unchecked memory allocation during vector deserialization
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
- GitHub Check: test
- GitHub Check: Analyze (go)
🔇 Additional comments (2)
consensus/misc/eip1559.go (1)
106-108: LGTM! Base fee reduction enables mainnet transaction replay on devnet.The change from 10000000 wei (0.01 Gwei) to 1 wei correctly addresses the devnet transaction replay issue by setting the minimum possible base fee. This ensures mainnet transactions with various gas price settings can be accepted on the shadow fork devnet without rejection due to base fee constraints. The change is properly scoped to shadow fork scenarios only via the Clique configuration check.
rollup/missing_header_fields/export-headers-toolkit/go.mod (1)
18-18: Clarify the relationship between dependency updates and the devnet fix.Eight indirect dependencies were updated in this PR, but these updates appear unrelated to the stated objective of fixing the devnet transaction replay issue. Dependency updates typically should be isolated in separate PRs for easier review and rollback if issues arise.
Can you confirm whether these dependency updates are:
- Required for the devnet replay fix
- Automatically updated by dependency management tools
- Intentionally bundled for other reasons
Also applies to: 21-22, 67-67, 75-78
1. Purpose or design rationale of this PR
Use 1 wei base fee in shadowfork network, to avoid replayed transactions failing with OOG.
2. PR title
Your PR title must follow conventional commits (as we are doing squash merge for each PR), so it must start with one of the following types:
3. Deployment tag versioning
Has the version in
params/version.gobeen updated?4. Breaking change label
Does this PR have the
breaking-changelabel?Summary by CodeRabbit