feat: async header transform #365
Merged
+29
−22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CodSpeed Performance ReportMerging #365 will not alter performanceComparing Summary
|
yiweichi
previously approved these changes
Nov 18, 2025
Member
yiweichi
left a comment
yiweichi
left a comment
There was a problem hiding this comment.
LGTM, I wonder do we have issue caused by this on sepolia/mainnet now? like a oom? or some block missing its signature on db?
yiweichi
approved these changes
Nov 18, 2025
Collaborator
Author
No, this is only a problem when we sync from genesis. Please also review the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Previously, the
mapmethod on theHeaderTransformtrait was synchronous. To work around this constraint in therollup-nodewe would spawn a new background task to insert the signatures into the database. However, this resulted in an unbounded number of tokio tasks responsible for inserting singatures into the database being spawned. In this PR we make the map methodasyncandawaitthe result of themapmethod before we send the result to the client. This provides a natural backpressure on the system.