Skip to content

Conversation

@yiweichi
Copy link
Member

@yiweichi yiweichi commented Nov 18, 2025

This PR fix the issue of l1 watcher, which we check if notifications.len() == logs.len. But this check won't pass if logs contains commit/finalized genesis event batch. So we change the condition to notifications.len() > logs.len() which we still can catch most bugs.

corresponding issue: #424

@codspeed-hq
Copy link

codspeed-hq bot commented Nov 18, 2025

CodSpeed Performance Report

Merging #429 will not alter performance

Comparing fix-l1-watch-log-check (2ee33fd) with main (655baa7)

Summary

✅ 2 untouched

@yiweichi yiweichi requested a review from frisitano November 18, 2025 20:12
@frisitano frisitano merged commit 3d0b03f into main Nov 19, 2025
17 of 18 checks passed
@frisitano frisitano deleted the fix-l1-watch-log-check branch November 19, 2025 05:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants