Skip to content

Conversation

@frisitano
Copy link
Collaborator

@frisitano frisitano commented Nov 19, 2025

Overview

This PR implements 2 changes:

  • Ensures that notifications are sent in the same order as their corresponding log was emitted on L1
  • Changes the logic of batch reverts such that we do not update the fcs when we are still actively syncing from L1.

TODO

In a follow-up issue, we should clean up some unnecessary code in the watcher related to the old log parsing pattern.

@codspeed-hq
Copy link

codspeed-hq bot commented Nov 19, 2025

CodSpeed Performance Report

Merging #432 will not alter performance

Comparing feat/watcher-event-ordering (762f2b5) with main (648b929)

Summary

✅ 2 untouched

Copy link
Member

@yiweichi yiweichi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@frisitano frisitano merged commit d6a78f9 into main Nov 19, 2025
15 checks passed
@frisitano frisitano deleted the feat/watcher-event-ordering branch November 19, 2025 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants