Skip to content

Conversation

@roynalnaruto
Copy link
Contributor

@roynalnaruto roynalnaruto commented Nov 21, 2025

Closes #151

The PR fixes the messy progress bar display in terminal when witnesses for a range of blocks are being dumped.

  • Uses MultiProgress and adds each ProgressBar to it
  • Removes printlns
  • Minor changes to the message
  • Uses tokio::fs instead of std::fs for async writing to file

The progress bar now updates the message on the same line (for each tokio task) instead of moving to the next line.

Terminal output from this approach seems much more cleaner and clearer.

Demo

out

Copy link
Member

@lightsing lightsing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you also add .inspect(|e| dev_error!("{e}")) to L123 and L129 so we can see the actual error.

@lightsing
Copy link
Member

let me take this pr from here. thx @roynalnaruto

@lightsing lightsing merged commit 38b33b9 into master Nov 24, 2025
4 checks passed
@lightsing lightsing deleted the fix/bin-progress-bar branch November 24, 2025 04:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

dump_range mess up outputs

3 participants