Skip to content

[Fix] Issues for validium mode #194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Oct 9, 2025
Merged

[Fix] Issues for validium mode #194

merged 6 commits into from
Oct 9, 2025

Conversation

noel2004
Copy link
Member

  1. Complete the block hash fields in chunkinfo (add some cost in chunk circuit since we need to calculate one block hash from header)
  2. Skip all blob data validations for validium mode

The guest program has been released as 0.6.0-rc.3

@github-actions github-actions bot added crate-chunk-circuit Updates to the guest program chunk-circuit crate-batch-circuit Updates to the guest program batch-circuit crate-bundle-circuit Updates to the guest grogram bundle-circuit crate-integration Updates to the integration crate crate-circuits Any update made to the circuits, i.e. commitments reflect a change labels Sep 26, 2025
roynalnaruto
roynalnaruto requested changes Sep 28, 2025
View reviewed changes
Copy link
Collaborator

@roynalnaruto roynalnaruto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need more changes as detailed in the comment. This is definitely complete, but unsound at the moment.

@roynalnaruto
Soundness issues in Validium (#196)
6762217 
* fix: soundness issues in validium mode

* chore: rename method validium pi_hash
@roynalnaruto
chore: rename another pi_hash validium
0033dfb
roynalnaruto
roynalnaruto approved these changes Sep 30, 2025
View reviewed changes
Copy link
Collaborator

@roynalnaruto roynalnaruto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now.

@lispc lispc merged commit f37ff50 into feat/validium Oct 9, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@roynalnaruto roynalnaruto roynalnaruto approved these changes

@lispc lispc Awaiting requested review from lispc lispc is a code owner

@lightsing lightsing Awaiting requested review from lightsing lightsing is a code owner

Assignees

No one assigned

Labels

crate-batch-circuit Updates to the guest program batch-circuit crate-bundle-circuit Updates to the guest grogram bundle-circuit crate-chunk-circuit Updates to the guest program chunk-circuit crate-circuits Any update made to the circuits, i.e. commitments reflect a change crate-integration Updates to the integration crate

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@noel2004 @roynalnaruto @lispc