Skip to content

chore: upgrade revm, reth and sbv #217

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Nov 11, 2025
Merged

chore: upgrade revm, reth and sbv #217

merged 6 commits into from
Nov 11, 2025

Conversation

@lightsing
Copy link
Member

@lightsing lightsing commented Nov 10, 2025

No description provided.

@github-actions github-actions bot added the crate-integration Updates to the integration crate label Nov 10, 2025
@lightsing lightsing marked this pull request as ready for review November 10, 2025 09:14
@roynalnaruto
Copy link
Collaborator

roynalnaruto commented Nov 10, 2025

@lightsing some (or most) of the changes here have already been included in #214.

Please check which changes aren't included and you can PR them to feat/galileo instead.

@lightsing
Copy link
Member Author

lightsing commented Nov 10, 2025

@lightsing some (or most) of the changes here have already been included in #214.

Please check which changes aren't included and you can PR them to feat/galileo instead.

I need to update master asap.

roynalnaruto
roynalnaruto approved these changes Nov 10, 2025
View reviewed changes
Copy link
Collaborator

@roynalnaruto roynalnaruto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Approving now as it's important to get included in master.

However, I feel like the naming for various witness types is now getting out of hand/partly confusing.

Creating an issue #218 for a future refactoring.

@github-actions github-actions bot added crate-chunk-circuit Updates to the guest program chunk-circuit crate-batch-circuit Updates to the guest program batch-circuit crate-bundle-circuit Updates to the guest grogram bundle-circuit crate-circuits Any update made to the circuits, i.e. commitments reflect a change labels Nov 10, 2025
@lispc lispc merged commit 0d964cd into master Nov 11, 2025
5 checks passed
@lightsing lightsing deleted the chore/upgrade branch November 11, 2025 02:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@roynalnaruto roynalnaruto roynalnaruto approved these changes

@noel2004 noel2004 noel2004 approved these changes

@lispc lispc Awaiting requested review from lispc lispc is a code owner

Assignees

No one assigned

Labels

crate-batch-circuit Updates to the guest program batch-circuit crate-bundle-circuit Updates to the guest grogram bundle-circuit crate-chunk-circuit Updates to the guest program chunk-circuit crate-circuits Any update made to the circuits, i.e. commitments reflect a change crate-integration Updates to the integration crate

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@lightsing @roynalnaruto @noel2004 @lispc