Skip to content

Conversation

@mike-zueff
Copy link
Contributor

Hello @scrooloose,

Within this pull request I propose the fix in order to allow read-only files to be opened as well as regular files.

@PhilRunninger
Copy link
Member

👍

3 similar comments
@rmk135
Copy link

rmk135 commented May 5, 2016

👍

@mrbish
Copy link

mrbish commented May 5, 2016

👍

@ghost
Copy link

ghost commented May 5, 2016

👍

@silvester747
Copy link

I would really want this fix to go in asap. Currently NerdTree is not usable for me, as my scm makes all files read-only...

@bearlin
Copy link

bearlin commented May 9, 2016

Rollback below change will also fix this issue, thanks for @mike-zueff's patch just fix it very well:
dfb9111

@bill-bishop
Copy link

This is great!!!

@mkoskar
Copy link

mkoskar commented May 11, 2016

Looking at dfb9111#diff-f094542718c161e8482e397da4e1f499L378 there is no need to introduce exec there.

Instead of

exec 'let line = substitute (line, " \['.g:NERDTreeGlyphReadOnly.'\]", "","")'

just do

let line = substitute (line, ' \['.g:NERDTreeGlyphReadOnly.'\]', "","")

@mike-zueff would you mind updating your PR? Thanks ;)

@scrooloose scrooloose merged commit 5294593 into preservim:master May 11, 2016
@scrooloose
Copy link
Collaborator

Merged, thanks for the fix!

@mkoskar
Copy link

mkoskar commented May 11, 2016

@scrooloose Maybe I'm missing something but is that exec really necessary there?

scrooloose added a commit that referenced this pull request May 11, 2016
@scrooloose
Copy link
Collaborator

@mkoskar - good point.

@mike-zueff mike-zueff deleted the read-only_files_opening_fix branch May 12, 2016 11:05
Leandros pushed a commit to Leandros/nerdtree that referenced this pull request Oct 21, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants