Crash on find match

[CTONishantBijani]

Hello Team,

i have successfully deployed under development server and was testing a bit for this amazing thing. i found consistent crash on find match API for enclave. Also i am C/C++ developer and would like to take voluntary participate to help society.

OS : Ubuntu 18.08

Crash Log using gdb :
[New Thread 0x7ffff35e0700 (LWP 16394)]
Thread 1 "safetrace-app" received signal SIGSEGV, Segmentation fault.
0x00005555555efda0 in safetrace_app::networking::ipc_listener::handling::find_match ()

[lacabra]

Hi @Embedded4development thanks for your interest in this project and your offer to help.

I'm in the process of documenting a number of things that need immediate work, and will link them here below. As you may guess one thing that needs more work that I'm aware is error management, so that in an instance like this, it would include a backtrace, and more details about the seg fault.

In the meantime and in order to help troubleshoot this issue, it would be great if you could post the data that you have loaded in the enclave, and the data that you are passing to find a match.

Thanks again 🙏

[CTONishantBijani]

Hello @lacabra
i am passing following data :

module.exports.DataUser1 = [
  {
    "lat": 40.757339,
    "lng": -73.985992,
    "startTS": 1583064001,
    "endTS": 1583067601,
    "testResult": false,
  },
  {
    "lat": 40.793840,
    "lng": -73.956900,
    "startTS": 1583150401,
    "endTS": 1583154001,
    "testResult": false,
  },
]

module.exports.DataUser2 = [
  {
    "lat": 41.757339,
    "lng": -73.985992,
    "startTS": 1583064000,
    "endTS": 1583067600,
    "testResult": true,
  },
  {
    "lat": 40.793840,
    "lng": -73.956900,
    "startTS": 1583150400,
    "endTS": 1583154000,
    "testResult": true,
  },
]

As per Following example from index.js i am passing data as well as finding match too :

addData('user1', JSON.stringify(data.DataUser1));
addData('user2', JSON.stringify(data.DataUser2));

findMatch('user1');

[lacabra]

ah, yes, I believe I know why this happens. I need to update the documentation on how to set up the environment. I believe it crashes because it's using incompatible versions. Let me document it better, and point you to the right docs... bear with me...

[lacabra]

@Embedded4development look at the changes introduced in this PR #44, which I believe address the underlying issue you are seeing.

Specifically, this section summarizes the changes between your current setup, and the setup you should have to make this repo work. So you should:

1. Uninstall the SGX driver and the SDK that you have installed.

2. Reinstall the correct version of SGX and SDK (I'm copying the relevant lines from the INSTALL.md doc.

cd "$HOME/.sgxsdk"
wget https://download.01.org/intel-sgx/linux-2.6/ubuntu18.04-server/sgx_linux_x64_driver_2.5.0_2605efa.bin
wget https://download.01.org/intel-sgx/linux-2.6/ubuntu18.04-server/sgx_linux_x64_sdk_2.6.100.51363.bin
wget https://download.01.org/intel-sgx/linux-2.6/ubuntu18.04-server/libsgx-enclave-common_2.6.100.51363-bionic1_amd64.deb
wget https://download.01.org/intel-sgx/linux-2.6/ubuntu18.04-server/libsgx-enclave-common-dev_2.6.100.51363-bionic1_amd64.deb

chmod +x ./sgx_linux_*.bin

sudo ./sgx_linux_x64_driver_*.bin

echo yes | ./sgx_linux_x64_sdk_*.bin

dpkg -i libsgx-enclave-common_2.6.100.51363-bionic1_amd64.deb
dpkg -i libsgx-enclave-common-dev_2.6.100.51363-bionic1_amd64.deb
sudo apt install -y  libsgx-urts libsgx-uae-service libsgx-launch libsgx-ae-le autoconf libtool

[CTONishantBijani]

@lacabra please update /safetrace/app/Cargo.toml as well for incubator-teaclave-sgx-sdk path

[CTONishantBijani]

Also, After running updated script on Ubuntu 18.04, sgx-detect is giving me following output :

`Detecting SGX, this may take a minute...
✔ SGX instruction set
✔ CPU support
✔ CPU configuration
✔ Enclave attributes
✔ Enclave Page Cache
SGX features
✘ SGX2 ✘ EXINFO ✘ ENCLV ✘ OVERSUB
Total EPC size: 93.5MiB
✘ Flexible launch control
✘ CPU support
✘ SGX system software
✘ SGX kernel device
✔ libsgx_enclave_common
✔ AESM service
✘ Able to launch enclaves
✘ Debug mode

🕮 SGX system software > SGX kernel device
The SGX device (/dev/sgx or /dev/isgx) is not present.

It appears you don't have the kernel module installed. Would you like to install it now?
(not supported yet)

(run with --verbose for more details)

More information: https://edp.fortanix.com/docs/installation/help/#sgx-driver

🕮 SGX system software > Able to launch enclaves > Debug mode
The enclave could not be launched.

(run with --verbose for more details)

More information: https://edp.fortanix.com/docs/installation/help/#run-enclave-debug
`

[CTONishantBijani]

previously it was
✔ Able to launch enclaves
✔ Debug mode
✔ Production mode (Intel whitelisted)

[CTONishantBijani]

Sharing output of updated SGX driver installation script here :

`script.sh: 3: script.sh: cannot open 16: No such file
script.sh: 3: script.sh: 18: not found
script.sh: 6: script.sh: cannot open 18: No such file
script.sh: 6: script.sh: 18: not found


#######################################
##### Installing missing packages #####
#######################################


Reading package lists... Done
Building dependency tree       
Reading state information... Done
gdebi is already the newest version (0.9.5.7+nmu2).
lynx is already the newest version (2.8.9dev16-3).
parallel is already the newest version (20161222-1).
The following packages were automatically installed and are no longer required:
  gyp libjs-async libjs-jquery libjs-node-uuid libjs-underscore libsgx-ae-epid libsgx-ae-pce libsgx-ae-qe3 libuv1-dev node-ansi node-ansi-color-table node-archy node-async node-balanced-match
  node-block-stream node-brace-expansion node-builtin-modules node-combined-stream node-concat-map node-cookie-jar node-delayed-stream node-forever-agent node-form-data node-fs.realpath node-fstream
  node-fstream-ignore node-github-url-from-git node-glob node-graceful-fs node-hosted-git-info node-inflight node-is-builtin-module node-json-stringify-safe node-lockfile node-lru-cache node-mime
  node-minimatch node-mkdirp node-mute-stream node-node-uuid node-normalize-package-data node-npmlog node-once node-osenv node-path-is-absolute node-pseudomap node-qs node-read node-read-package-json
  node-request node-retry node-rimraf node-semver node-sha node-slide node-spdx-correct node-spdx-expression-parse node-spdx-license-ids node-tar node-tunnel-agent node-underscore
  node-validate-npm-package-license node-wrappy node-yallist python-cliapp python-markdown python-pygments python-ttystatus python-yaml
Use 'sudo apt autoremove' to remove them.
0 upgraded, 0 newly installed, 0 to remove and 195 not upgraded.


################################################
##### Downloading Intel SGX driver and SDK #####
################################################


--2020-04-04 16:44:18--  https://download.01.org/intel-sgx/linux-2.6/ubuntu18.04-server/sgx_linux_x64_driver_2.5.0_2605efa.bin
Resolving download.01.org (download.01.org)... 104.69.144.73, 2600:140f:4:684::4b21, 2600:140f:4:69f::4b21
Connecting to download.01.org (download.01.org)|104.69.144.73|:443... connected.
HTTP request sent, awaiting response... 200 OK
Length: 28686 (28K) [application/octet-stream]
Saving to: ‘sgx_linux_x64_driver_2.5.0_2605efa.bin.1’

sgx_linux_x64_driver_2.5.0_2605efa.bin.1           100%[================================================================================================================>]  28.01K  --.-KB/s    in 0.07s   

2020-04-04 16:44:18 (383 KB/s) - ‘sgx_linux_x64_driver_2.5.0_2605efa.bin.1’ saved [28686/28686]

--2020-04-04 16:44:18--  https://download.01.org/intel-sgx/linux-2.6/ubuntu18.04-server/sgx_linux_x64_sdk_2.6.100.51363.bin
Resolving download.01.org (download.01.org)... 104.69.144.73, 2600:140f:4:684::4b21, 2600:140f:4:69f::4b21
Connecting to download.01.org (download.01.org)|104.69.144.73|:443... connected.
HTTP request sent, awaiting response... 200 OK
Length: unspecified [application/octet-stream]
Saving to: ‘sgx_linux_x64_sdk_2.6.100.51363.bin.1’

sgx_linux_x64_sdk_2.6.100.51363.bin.1                  [                                    <=>                                                                          ]  18.47M  2.81MB/s    in 7.4s    

2020-04-04 16:44:26 (2.49 MB/s) - ‘sgx_linux_x64_sdk_2.6.100.51363.bin.1’ saved [19370152]

--2020-04-04 16:44:26--  https://download.01.org/intel-sgx/linux-2.6/ubuntu18.04-server/libsgx-enclave-common_2.6.100.51363-bionic1_amd64.deb
Resolving download.01.org (download.01.org)... 104.69.144.73, 2600:140f:4:684::4b21, 2600:140f:4:69f::4b21
Connecting to download.01.org (download.01.org)|104.69.144.73|:443... connected.
HTTP request sent, awaiting response... 200 OK
Length: 1708000 (1.6M) [application/x-debian-package]
Saving to: ‘libsgx-enclave-common_2.6.100.51363-bionic1_amd64.deb.1’

libsgx-enclave-common_2.6.100.51363-bionic1_amd64. 100%[================================================================================================================>]   1.63M  1.78MB/s    in 0.9s    

2020-04-04 16:44:27 (1.78 MB/s) - ‘libsgx-enclave-common_2.6.100.51363-bionic1_amd64.deb.1’ saved [1708000/1708000]

--2020-04-04 16:44:27--  https://download.01.org/intel-sgx/linux-2.6/ubuntu18.04-server/libsgx-enclave-common-dev_2.6.100.51363-bionic1_amd64.deb
Resolving download.01.org (download.01.org)... 104.69.144.73, 2600:140f:4:684::4b21, 2600:140f:4:69f::4b21
Connecting to download.01.org (download.01.org)|104.69.144.73|:443... connected.
HTTP request sent, awaiting response... 200 OK
Length: 26688 (26K) [application/x-debian-package]
Saving to: ‘libsgx-enclave-common-dev_2.6.100.51363-bionic1_amd64.deb.1’

libsgx-enclave-common-dev_2.6.100.51363-bionic1_am 100%[================================================================================================================>]  26.06K  --.-KB/s    in 0.07s   

2020-04-04 16:44:27 (358 KB/s) - ‘libsgx-enclave-common-dev_2.6.100.51363-bionic1_amd64.deb.1’ saved [26688/26688]



###############################################
##### Installing Intel SGX driver and SDK #####
###############################################


Unpacking Intel SGX Driver ... done.
Verifying the integrity of the install package ... done.
Installing Intel SGX Driver ...
/tmp/sgx-driver-JcjIC7 ~/.sgxsdk
install -d /opt/intel/sgxdriver/package
install -d /opt/intel/sgxdriver/scripts
install package/* /opt/intel/sgxdriver/package
install scripts/* /opt/intel/sgxdriver/scripts
~/.sgxsdk
/opt/intel/sgxdriver/package ~/.sgxsdk
make -C /lib/modules/5.3.0-42-generic/build SUBDIRS=/opt/intel/sgxdriver/package modules
make[1]: Entering directory '/usr/src/linux-headers-5.3.0-42-generic'
Makefile:227: ================= WARNING ================
Makefile:228: 'SUBDIRS' will be removed after Linux 5.3
Makefile:229: 
Makefile:230: If you are building an individual subdirectory
Makefile:231: in the kernel tree, you can do like this:
Makefile:232: $ make path/to/dir/you/want/to/build/
Makefile:233: (Do not forget the trailing slash)
Makefile:234: 
Makefile:235: If you are building an external module,
Makefile:236: Please use 'M=' or 'KBUILD_EXTMOD' instead
Makefile:237: ==========================================
  CC [M]  /opt/intel/sgxdriver/package/sgx_main.o
  CC [M]  /opt/intel/sgxdriver/package/sgx_page_cache.o
/opt/intel/sgxdriver/package/sgx_page_cache.c: In function ‘sgx_test_and_clear_young’:
/opt/intel/sgxdriver/package/sgx_page_cache.c:126:8: error: passing argument 4 of ‘apply_to_page_range’ from incompatible pointer type [-Werror=incompatible-pointer-types]
        sgx_test_and_clear_young_cb, vma->vm_mm);
        ^~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from /opt/intel/sgxdriver/package/sgx.h:72:0,
                 from /opt/intel/sgxdriver/package/sgx_page_cache.c:61:
./include/linux/mm.h:2678:12: note: expected ‘pte_fn_t {aka int (*)(struct <anonymous> *, long unsigned int,  void *)}’ but argument is of type ‘int (*)(pte_t *, struct page *, long unsigned int,  void *) {aka int (*)(struct <anonymous> *, struct page *, long unsigned int,  void *)}’
 extern int apply_to_page_range(struct mm_struct *mm, unsigned long address,
            ^~~~~~~~~~~~~~~~~~~
cc1: some warnings being treated as errors
scripts/Makefile.build:288: recipe for target '/opt/intel/sgxdriver/package/sgx_page_cache.o' failed
make[2]: *** [/opt/intel/sgxdriver/package/sgx_page_cache.o] Error 1
Makefile:1655: recipe for target '_module_/opt/intel/sgxdriver/package' failed
make[1]: *** [_module_/opt/intel/sgxdriver/package] Error 2
make[1]: Leaving directory '/usr/src/linux-headers-5.3.0-42-generic'
Makefile:16: recipe for target 'default' failed
make: *** [default] Error 2

Do you want to install in current directory? [yes/no] : Unpacking Intel SGX SDK ... done.
Verifying the integrity of the install package ... done.
Installing Intel SGX SDK ... done.
/tmp/sgx-sdk-ybRp2E ~/.sgxsdk
install -d /home/nishant/.sgxsdk/sgxsdk
cp -r package/* /home/nishant/.sgxsdk/sgxsdk
install -d /home/nishant/.sgxsdk/sgxsdk/scripts
install scripts/* /home/nishant/.sgxsdk/sgxsdk/scripts
chmod +x /home/nishant/.sgxsdk/sgxsdk/bin/sgx-gdb
~/.sgxsdk
uninstall.sh script generated in /home/nishant/.sgxsdk/sgxsdk

Installation is successful! The SDK package can be found in /home/nishant/.sgxsdk/sgxsdk

Please set the environment variables with below command:

source /home/nishant/.sgxsdk/sgxsdk/environment


##############################################
##### Installing additional dependencies #####
##############################################


deb [arch=amd64] https://download.01.org/intel-sgx/sgx_repo/ubuntu bionic main
OK
Hit:1 http://linux.teamviewer.com/deb stable InRelease
Hit:2 http://in.archive.ubuntu.com/ubuntu bionic InRelease                                                                                                                                                 
Get:3 http://in.archive.ubuntu.com/ubuntu bionic-updates InRelease [88.7 kB]                                                                                                                               
Ign:4 http://dl.google.com/linux/chrome/deb stable InRelease                                                                                                                                               
Ign:5 https://repo.mongodb.org/apt/ubuntu bionic/mongodb-org/4.2 InRelease                                                                                                                                 
Hit:6 https://repo.mongodb.org/apt/ubuntu bionic/mongodb-org/4.2 Release                                                                                                                                   
Get:7 http://in.archive.ubuntu.com/ubuntu bionic-backports InRelease [74.6 kB]                                                                                                                             
Hit:8 https://dl.yarnpkg.com/debian stable InRelease                                                                                                                                                       
Hit:9 http://ppa.launchpad.net/linuxgndu/sqlitebrowser/ubuntu bionic InRelease                                                                                                                             
Get:10 http://in.archive.ubuntu.com/ubuntu bionic-updates/main amd64 DEP-11 Metadata [307 kB]                                                                                                              
Hit:11 http://dl.google.com/linux/chrome/deb stable Release                                                                                                                                                
Hit:13 http://ppa.launchpad.net/notepadqq-team/notepadqq/ubuntu bionic InRelease                                                                                                                           
Get:14 http://security.ubuntu.com/ubuntu bionic-security InRelease [88.7 kB]                                                                                                                               
Hit:15 https://download.01.org/intel-sgx/sgx_repo/ubuntu bionic InRelease                                                                                                                                  
Get:16 http://in.archive.ubuntu.com/ubuntu bionic-updates/main DEP-11 48x48 Icons [73.8 kB]                                                                                                                
Get:17 http://in.archive.ubuntu.com/ubuntu bionic-updates/main DEP-11 64x64 Icons [140 kB]                                                                                                                 
Get:18 http://in.archive.ubuntu.com/ubuntu bionic-updates/universe amd64 Packages [1,061 kB]                                                                                                               
Hit:19 http://ppa.launchpad.net/ubuntuhandbook1/audacity/ubuntu bionic InRelease                                                                                                                         
Hit:21 https://download.sublimetext.com apt/stable/ InRelease                                                                                                                 
Hit:22 http://ppa.launchpad.net/webupd8team/java/ubuntu bionic InRelease                                                                       
Get:23 http://in.archive.ubuntu.com/ubuntu bionic-updates/universe i386 Packages [1,012 kB]                              
Get:24 http://in.archive.ubuntu.com/ubuntu bionic-updates/universe amd64 DEP-11 Metadata [273 kB]                          
Get:25 http://in.archive.ubuntu.com/ubuntu bionic-updates/universe DEP-11 48x48 Icons [204 kB]
Get:26 http://in.archive.ubuntu.com/ubuntu bionic-updates/universe DEP-11 64x64 Icons [472 kB]
Get:27 http://in.archive.ubuntu.com/ubuntu bionic-updates/multiverse amd64 DEP-11 Metadata [2,468 B]
Get:28 http://in.archive.ubuntu.com/ubuntu bionic-backports/universe amd64 DEP-11 Metadata [7,980 B]
Fetched 3,806 kB in 2s (1,534 kB/s)                                       
Reading package lists... Done
Building dependency tree       
Reading state information... Done
195 packages can be upgraded. Run 'apt list --upgradable' to see them.
--2020-04-04 16:44:46--  http://ftp.br.debian.org/debian/pool/main/p/protobuf/libprotobuf10_3.0.0-9_amd64.deb
Resolving ftp.br.debian.org (ftp.br.debian.org)... 200.236.31.3, 2801:82:80ff:8000::4
Connecting to ftp.br.debian.org (ftp.br.debian.org)|200.236.31.3|:80... connected.
HTTP request sent, awaiting response... 200 OK
Length: 680836 (665K) [application/x-debian-package]
Saving to: ‘/tmp/libprotobuf10_3.0.0-9_amd64.deb’

/tmp/libprotobuf10_3.0.0-9_amd64.deb               100%[================================================================================================================>] 664.88K   132KB/s    in 5.0s    

2020-04-04 16:44:52 (132 KB/s) - ‘/tmp/libprotobuf10_3.0.0-9_amd64.deb’ saved [680836/680836]

Reading package lists... Done
Building dependency tree        
Reading state information... Done
This package is uninstallable
A later version is already installed
dpkg: error: cannot access archive 'libsgx-enclave-common_2.6.100.51363-bionic1_amd64.deb': No such file or directory
dpkg: error: cannot access archive 'libsgx-enclave-common-dev_2.6.100.51363-bionic1_amd64.deb': No such file or directory
Reading package lists... Done
Building dependency tree       
Reading state information... Done
autoconf is already the newest version (2.69-11).
libtool is already the newest version (2.4.6-2).
libsgx-ae-le is already the newest version (2.9.100.2-bionic1).
libsgx-launch is already the newest version (2.9.100.2-bionic1).
libsgx-uae-service is already the newest version (2.9.100.2-bionic1).
libsgx-urts is already the newest version (2.9.100.2-bionic1).
The following packages were automatically installed and are no longer required:
  gyp libjs-async libjs-jquery libjs-node-uuid libjs-underscore libsgx-ae-epid libsgx-ae-pce libsgx-ae-qe3 libuv1-dev node-ansi node-ansi-color-table node-archy node-async node-balanced-match
  node-block-stream node-brace-expansion node-builtin-modules node-combined-stream node-concat-map node-cookie-jar node-delayed-stream node-forever-agent node-form-data node-fs.realpath node-fstream
  node-fstream-ignore node-github-url-from-git node-glob node-graceful-fs node-hosted-git-info node-inflight node-is-builtin-module node-json-stringify-safe node-lockfile node-lru-cache node-mime
  node-minimatch node-mkdirp node-mute-stream node-node-uuid node-normalize-package-data node-npmlog node-once node-osenv node-path-is-absolute node-pseudomap node-qs node-read node-read-package-json
  node-request node-retry node-rimraf node-semver node-sha node-slide node-spdx-correct node-spdx-expression-parse node-spdx-license-ids node-tar node-tunnel-agent node-underscore
  node-validate-npm-package-license node-wrappy node-yallist python-cliapp python-markdown python-pygments python-ttystatus python-yaml
Use 'sudo apt autoremove' to remove them.
0 upgraded, 0 newly installed, 0 to remove and 195 not upgraded.`

[lacabra]

Replying to:

@lacabra please update /safetrace/app/Cargo.toml as well for incubator-teaclave-sgx-sdk path

Done in #49

[CTONishantBijani]

Any update for other issues @lacabra ?

[lacabra]

@Embedded4development, your driver installation failed in your script above. The error is here:

/opt/intel/sgxdriver/package/sgx_page_cache.c: In function ‘sgx_test_and_clear_young’:
/opt/intel/sgxdriver/package/sgx_page_cache.c:126:8: error: passing argument 4 of ‘apply_to_page_range’ from incompatible pointer type [-Werror=incompatible-pointer-types]
        sgx_test_and_clear_young_cb, vma->vm_mm);
        ^~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from /opt/intel/sgxdriver/package/sgx.h:72:0,
                 from /opt/intel/sgxdriver/package/sgx_page_cache.c:61:
./include/linux/mm.h:2678:12: note: expected ‘pte_fn_t {aka int (*)(struct <anonymous> *, long unsigned int,  void *)}’ but argument is of type ‘int (*)(pte_t *, struct page *, long unsigned int,  void *) {aka int (*)(struct <anonymous> *, struct page *, long unsigned int,  void *)}’
 extern int apply_to_page_range(struct mm_struct *mm, unsigned long address,
            ^~~~~~~~~~~~~~~~~~~
cc1: some warnings being treated as errors
scripts/Makefile.build:288: recipe for target '/opt/intel/sgxdriver/package/sgx_page_cache.o' failed
make[2]: *** [/opt/intel/sgxdriver/package/sgx_page_cache.o] Error 1
Makefile:1655: recipe for target '_module_/opt/intel/sgxdriver/package' failed
make[1]: *** [_module_/opt/intel/sgxdriver/package] Error 2
make[1]: Leaving directory '/usr/src/linux-headers-5.3.0-42-generic'
Makefile:16: recipe for target 'default' failed
make: *** [default] Error 2

Everything else looks good.

I just tried reinstalling this driver, and it works fine for me.

Can you try this newer version?

wget https://download.01.org/intel-sgx/sgx-linux/2.9/distro/ubuntu16.04-server/sgx_linux_x64_driver_2.6.0_95eaa6f.bin
chmod +x sgx_linux_x64_driver_2.6.0_95eaa6f.bin
sudo ./sgx_linux_x64_driver_2.6.0_95eaa6f.bin

[CTONishantBijani]

Okay, so it was issue with full script.
i did it by following step by step script commands and everything works well.