Skip to content

Conversation

@itsHaseebSaeed
Copy link
Contributor

No description provided.

Copy link
Contributor

@reuvenpo reuvenpo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this PR @Haseeb30000 !
It removes a lot of unnecessary dev-dependencies that were being pulled in when compiling tests, and were only built successfully on machines of devs that already had various SGX components installed on their machines. This will let anyone run the tests without all the hassle :)

@reuvenpo reuvenpo merged commit 9e51ac4 into scrtlabs:master Jul 13, 2021
@assafmo
Copy link
Contributor

assafmo commented Jul 14, 2021

@Haseeb30000 👑

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants